Test on Windows and macOS, await closing databases - #159
Merged
Conversation
simolus3
commented
Aug 27, 2026
rkistner
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands native Dart VM tests to also run on macOS and Windows (previously we only tested this package on Ubuntu). Testing on Windows adds an implicit assertion that we clean up all database resources before a test is complete: Deleting files or directories that still have opened file handles fails on Windows.
To get tests to work on Windows, this closes test databases before we get to the
tearDowndeleting database files. This requires two fixes:NativeSqliteDatabaseImpl.close(), actually wait for all connections to be closed. To ensure no concurrent lease is active, we request exclusive access to the pool and only complete the future once everything is closed. Additionally, we now wait for worker isolates to have shut down.sqlite3_web, but this patches tests to stop using the database before returning.We don't run web tests on other operating systems: We expect Chrome to behave the same on all platforms, so we can treat it as a single target and don't need to run those tests multiple times.
This is related to powersync-ja/powersync.dart#460.
AI use: I used Claude Code for GH actions changes.