Fix provenance for lookups with multiple inputs - #780
Merged
Conversation
Co-authored-by: Ben Kraus <[email protected]>
🦋 Changeset detectedLatest commit: a5e5989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
approved these changes
Sep 1, 2026
Contributor
|
Thanks for reviewing my clankers’ fix! Hope some of the docs at least were helpful |
Contributor
Author
|
Thanks for sharing the patch! We'll also use this opportunity to replace the whole provenance thing with something that is much easier to understand: #782. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the patch contributed through this analysis repo: For lookups with multiple inputs, we'd previously generate a fresh symbol in every iteration calling
setOrUpdate. This is incorrect, the outputs are part of the same materialized result set and should not be combined later.The patch was generated by Codex, I manually reviewed changes and made some slight test simplifications.
I want to take a look at removing the provenance system altogether in favor of something that is actually capable of performing joins. That is a bigger change though, so this is another quick fix for the current approach.