-
Notifications
You must be signed in to change notification settings - Fork 7
New checkpoint request protocol #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LucDeCaf
wants to merge
9
commits into
main
Choose a base branch
from
checkpoint-requests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
718b064
block out
LucDeCaf 3e84a59
more partial work
LucDeCaf bbf39f2
delete \;
LucDeCaf 5126349
Checkpoint state, bucket storage adapter, build no longer errors
LucDeCaf 9ea7be9
Refactor StreamingSyncImplementation, rewrite CheckpointStateSignals,…
LucDeCaf f9dc1da
don't throw in DelayRetry
LucDeCaf bc58b60
reduce test warnings
LucDeCaf 3f3041a
readd Next/Current/SeedCheckpointRequestId methods
LucDeCaf fa5018d
Readd BroadcastChannel, dynamic error creation, fix using non-netstan…
LucDeCaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
PowerSync/PowerSync.Common/Client/Sync/CheckpointRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| namespace PowerSync.Common.Client.Sync; | ||
|
|
||
| /// <summary>An exception related to checkpoint requests.</summary> | ||
| public class CheckpointRequestException : Exception | ||
|
LucDeCaf marked this conversation as resolved.
|
||
| { | ||
| /// <summary>Initializes a new instance of the <see cref="CheckpointRequestException" /> class.</summary> | ||
| public CheckpointRequestException() : base() { } | ||
|
|
||
| /// <summary>Initializes a new instance of the <see cref="CheckpointRequestException" /> class with a specified error message.</summary> | ||
| public CheckpointRequestException(string message) : base(message) { } | ||
|
|
||
| /// <summary>Initializes a new instance of the <see cref="CheckpointRequestException" /> class with a specified error message and a reference to the inner exception that is the cause of this exception.</summary> | ||
| public CheckpointRequestException(string message, Exception innerException) : base(message, innerException) { } | ||
|
|
||
| /// <summary>The connected PowerSync Service does not support checkpoint requests.</summary> | ||
| public static readonly string InstanceNotSupported = "The PowerSync service does not support checkpoint requests. Update to PowerSync service version 1.24.0 or later to use this API."; | ||
|
|
||
| /// <summary>The sync client is disconnected.</summary> | ||
| public static readonly string Disconnected = "Cannot request checkpoints, sync client is disconnected"; | ||
|
|
||
| /// <summary>Checkpoint requests are disabled; legacy write checkpoints are enabled.</summary> | ||
| public static readonly string Disabled = "Connected with legacy checkpoint mode, cannot request checkpoints"; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.