[Kart03]

Context

When a form-data File param has an array src, the multi-file branch of addFormParamsFile called the outer presend done() instead of the eachSeries callback. The remaining File params of the request were never loaded and no warning was emitted, so a second File field went out as an empty part.

Summary

• Call the series callback() in the multi-file branch (both the error path and the success path), so the next File param is loaded.
• Add integration tests: two and three array-src fields, an unresolved array src followed by a later field (warns once, later file sent), a string/array/string mix, and an array followed by an empty array.

Breaking changes

None.

Dependencies

None.

Test plan

• test/integration/file-uploads/multi-file-params.test.js: 5 tests. With the fix reverted all 5 fail; with it they pass.
• The existing file-upload integration tests (35) and unit tests (571) pass.
• The new tests post to postman-echo.com like the existing file-upload tests, so they need network.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.72%. Comparing base (e0fafea) to head (72f4bb5).

❌ Your project check has failed because the head coverage (34.10%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1569      +/-   ##
===========================================
+ Coverage    77.66%   77.72%   +0.06%     
===========================================
  Files           51       51              
  Lines         4369     4369              
  Branches      1234     1234              
===========================================
+ Hits          3393     3396       +3     
+ Misses         732      730       -2     
+ Partials       244      243       -1     

Flag	Coverage Δ
integration	68.98% <100.00%> (+0.11%)	⬆️
legacy	34.10% <0.00%> (ø)
unit	47.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[appurva21]

@Kart03 Looks good. Can you add the Changelog for this?

[Kart03]

@appurva21 Added the changelog entry under unreleased in CHANGELOG.yaml (a542929).