Repository navigation
Conversation
Under customParallelIterations the run has no run-level data: each
partition holds the row its host injected (partition.iterationData). The
nested request read state.data instead, so {{var}} from the data row went
out literally and pm.iterationData was empty in nested scripts.
Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (34.05%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feat/per-vu-iteration-data #1567 +/- ##
==============================================================
- Coverage 77.83% 77.78% -0.05%
==============================================================
Files 51 51
Lines 4380 4384 +4
Branches 1238 1239 +1
==============================================================
+ Hits 3409 3410 +1
- Misses 729 730 +1
- Partials 242 244 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1559, targeting its branch.
Problem: under
customParallelIterationsthe run has no run-leveldata; each partition holds the row its host injected (partition.iterationData).runNestedRequestbuilt the nested run's row fromstate.data, so in a per-VU-data run apm.execution.runRequesttarget sent{{col}}literally and saw an emptypm.iterationData. Found by the AUTO-1178 audit of performance runs (lib@postman/performance-testwith #1559 + #1565).Fix:
getParentIterationRow(run)picks the row from the calling partition (rootCursor.partitionIndex) when the run uses custom parallel iterations. The streaming and plain paths are unchanged.Tests: unit 612 passing here; lint clean. A run-level test needs #1565 as well (a nested run under
customParallelIterationshangs without it), so it lives on the #1559 + #1565 merge:test/integration/runner-spec/run-collection-request-parallel.test.js"with per-VU iteration data > should hand the nested request the calling VU's iteration data row", which fails before this change and passes after (runRequest specs 33 passing). The performance-test lib's run-level suite covers it too ({{var}}in the nested request andpm.iterationDatain nested scripts, 3 VUs).Generated with Claude Code