Skip to content

Improved SSE event buffering - #1564

Open
yashjain-sec wants to merge 1 commit into
developfrom
fix/sse-event-buffering
Open

yashjain-sec wants to merge 1 commit into
developfrom
fix/sse-event-buffering

Conversation

@yashjain-sec

Copy link
Copy Markdown
Member

Changes

  • Collect SSE event lines in a list and join them once when the event is emitted
  • Start the line scan from the current position instead of the start of the buffer

Tests

  • Added unit tests for SSEProcessor covering chunked input, BOM, CR / CRLF line endings and events with many lines

Generated with Claude Code

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.95%. Comparing base (9c2d10d) to head (46a8a66).

❌ Your project check has failed because the head coverage (34.33%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1564      +/-   ##
===========================================
+ Coverage    77.54%   78.95%   +1.41%     
===========================================
  Files           51       51              
  Lines         4338     4339       +1     
  Branches      1223     1221       -2     
===========================================
+ Hits          3364     3426      +62     
+ Misses         731      667      -64     
- Partials       243      246       +3     
Flag Coverage Δ
integration 68.72% <12.50%> (+<0.01%) ⬆️
legacy 34.33% <12.50%> (+0.01%) ⬆️
unit 48.28% <100.00%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant