Skip to content

Improved NTLM type 2 message parsing - #1563

Open
yashjain-sec wants to merge 1 commit into
developfrom
fix/ntlm-type2-parsing
Open

yashjain-sec wants to merge 1 commit into
developfrom
fix/ntlm-type2-parsing

Conversation

@yashjain-sec

Copy link
Copy Markdown
Member

Changes

  • Validate the NTLM type 2 message length before reading its fields
  • Report NTLM type 2 parsing failures through the auth error callback

Tests

  • Added unit tests for short type 2 messages in parseType2Message and the NTLM auth handler

Generated with Claude Code

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.66%. Comparing base (9c2d10d) to head (6463953).

Files with missing lines Patch % Lines
lib/authorizer/ntlm.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1563      +/-   ##
===========================================
+ Coverage    77.54%   77.66%   +0.12%     
===========================================
  Files           51       51              
  Lines         4338     4348      +10     
  Branches      1223     1225       +2     
===========================================
+ Hits          3364     3377      +13     
+ Misses         731      730       -1     
+ Partials       243      241       -2     
Flag Coverage Δ
integration 68.62% <36.36%> (-0.09%) ⬇️
legacy 34.29% <18.18%> (-0.04%) ⬇️
unit 47.37% <90.90%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant