The event record: a badge on the identity circle, a list behind it (#132) - #133
Merged
Conversation
…tity circle Design memo #132, NOTES entry included. The strip's timed announcement was one transient line multiplexing three jobs; the split gives each its mechanism: moment cues stay push (announce/pulse/speak, record-less), standing conditions become visor-held keyed state (set/clear, lit while standing, session-live), and event records become a persistent acknowledgeable list behind a dot on #visor-settings — lit = unseen records ∪ standing conditions, opened through a visor-owned settings-sheet row into a 'recent events' drawer tenant (erase-entry suspend/resume motion; opening marks seen). The mechanical rule that makes wiring one line per host: every consequential announcement leaves a record — hooked in visorAnnounceSink's consequential branch only (statusWriter never records). solo's sync watch now sets/clears the 'sync' condition and the edge return replaces its hand-rolled syncFailureAnnounced boolean, preserving announce-once-per-crossing exactly. Gates: e2e 36/36 — visor-events new (seeded stale boot cache drives a real reconcile-announced event into badge, list, seen, reload persistence); store-outage-recovery extended (condition lights the badge, failure record outlives the ambient recovery announce, condition block clears); strip-geometry now measures with the badge lit. Invariants green; harness and hosts type-check green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #132 (design memo filed from the announcements-vs-notification-list discussion; the NOTES.md entry in this PR is its summary).
What
setCondition/clearCondition, session-live, lit while standing); event records are a persistent, acknowledgeable list (addEvent/events/markEventsSeen/unseenEventCount, optionaleventsKeypersistence, cap 50,erase()wipes it).#visor-settings, absolutely positioned (zero layout shift —strip-geometrynow takes every measurement with the badge lit), framework voice by construction, lit = unseen ∪ standing. Author rule documented at the only door: engine/visor-authored text only.visorAnnounceSink's consequential branch (exactly-once verified: both hosts' consequential paths flow through that sink;statusWriternever records).syncFailureAnnouncededge-trigger boolean is replaced by the condition edge; announce-once-per-crossing preserved exactly.Review
Independent review against #132 + the three-voices policy: non-blocking; its one actionable advisory (strip-geometry should measure a lit badge rather than trust the CSS) is addressed in this PR, with a negative control run against a bogus seed key.
Gates
visor-eventsnew,store-outage-recoveryextended with the condition beats,strip-geometrylit)check-invariants.shgreen (incl. check (h): no newforeignassignments)just site/just e2e-check/ todomvc spike type-check green (noeventsKey→ in-memory, proving the config stays optional)Automerge will be armed per repo convention.