Repository navigation
Conversation
- Supply a real fetch closure on the verifiable probe in TestSweepRunOwnership, pairing verifiable: true with a GetNetworkDetails wrapper on the fake API - Add an allProbesGone assertion to exercise the new fetch and fail if the verifiable invariant is removed - Correct docs/development.md to credit allProbesGone (not waitForGone) as the function that gates polling on the verifiable field Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
lmilbaum
marked this pull request as ready for review
October 3, 2026 08:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchclosure on the verifiable probe inTestSweepRunOwnership, pairingverifiable: truewith aGetNetworkDetailswrapper on the fake API as required by the invariant introduced in test: mark the ownership probe verifiable and document the default #74.allProbesGoneassertion to exercise the new fetch and fail if theverifiableinvariant is removed.docs/development.mdto creditallProbesGone(notwaitForGone) as the function that gates polling on theverifiablefield.Fixes issues identified in the #74 audit.
Reviewer summary
Both audit findings are fully resolved with no new issues introduced:
e2e_ownership_test.go): probe now has a realfetch;allProbesGoneassertion guards the invariant.docs/development.md): attribution corrected fromwaitForGonetoallProbesGone.🤖 Generated with Claude Code