Repository navigation
Conversation
- docs/development.md: replace incorrect `GET /1.3/database/plans` with
`GET /1.3/database/service-types/{type}` for engine-version discovery
- Add `properties.version.enum` and `latest_available_version` field names
- Clarify that `/database/plans` returns compute shapes, not engine versions
Addresses audit finding from PR polarsquad#65 review.
Co-Authored-By: Claude Haiku 4.5 <[email protected]>
lmilbaum
marked this pull request as ready for review
October 3, 2026 06:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the troubleshooting guidance in
docs/development.mdintroduced by PR #65.The paragraph told maintainers to run
GET /1.3/database/plansto find validproperties.versionvalues when a e2e Ready wait fails with a 400. That endpointreturns compute plan shapes (e.g.
1x1xCPU-2GB-25GB), not engine versions.Change: points the guidance at
GET /1.3/database/service-types/{type}(e.g.GET /1.3/database/service-types/pg), names the response fields to read(
properties.version.enumfor the accepted set,latest_available_versionfor thenewest), and adds a clarifying sentence that
/database/planslists plan shapes.Addresses issues identified in the #65 audit.
Reviewer summary
HIGH finding fully resolved. No new HIGH or MEDIUM issues introduced. One LOW noted
(field name accuracy) — field names verified against vendored SDK
upcloud-go-api v8.41.0(upcloud.ManagedDatabaseType.LatestAvailableVersionandManagedDatabaseServiceProperty.Enum).🤖 Generated with Claude Code