Repository navigation
fix: address audit findings from PR #611 - #653
Merged
Merged
Conversation
- verify-package.sh: fix `local ZARF` shadowing so caller's ZARF override is respected - update-package.sh: replace bare `sync` with `sync "$STAGING/$ACTIVE_NAME"` - update-package.sh: replace `rmdir "$STAGING"` with `rm -rf "$STAGING"` after swap - update-package.sh: reject unknown/corrupted state phases in apply() (explicit allowlist) - update-package.sh: document TOCTOU limitation in acquire_lock comment - test-airgap-update-rollback.py: re-inject AIRGAP_VERIFY_WORKFLOW_REF in real-zarf mode - test-airgap-update-rollback.py: add 4 new stub scenarios covering the fixes - docs/airgap.md: note race-free limitation and unknown-state apply refusal Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local ZARFshadowing inverify-package.shthat silently ignored a caller-suppliedZARFenv var (MEDIUM)AIRGAP_VERIFY_WORKFLOW_REFin the real-zarf test harness so branch-dispatch real-zarf mode testing works correctly (MEDIUM)rmdir "$STAGING"withrm -rf "$STAGING"to prevent aset -eabort leavingphase=cutoverwith deploy never run (LOW)apply()state machine rejecting unknown/corrupted phases with a clear error (LOW/NOTE)syncwithsync "$STAGING/$ACTIVE_NAME"to limit filesystem flush scope (NOTE)acquire_lockand the unknown-state refusal indocs/airgap.mdtest-airgap-update-rollback.pyexercising each fixAudit findings identified in the #611 review by @shrinedogg.
🤖 Generated with Claude Code