Repository navigation
feat(store): the install button opens Pocket Hub on the app - #21
Merged
Merged
Conversation
An app's page hands the app to Pocket Hub through a link the system opens Hub's Mac app with: pocket-hub://store/app/<id>. hubInstallLink builds it, and Pocket Hub's docs/DEEP-LINKS.md is the contract: the link carries the id and nothing else, and following it shows the app in Hub, where the owner installs it. A browser does not tell a page whether such a link opened anything, so once a visitor has followed it the page says what should have happened and what is missing when nothing did. The words go in the row under the screen, so the app's name does not move. The disabled "Not open yet" state of the button is gone with its string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An app's page now hands the app to Pocket Hub. The install button is a link the system opens Hub's Mac app with:
hubInstallLinkinstore/site/src/hub.tsbuilds it, and Pocket Hub'sdocs/DEEP-LINKS.mdis the contract (pocket-nexus/pocket-hub#7 is Hub's side). The link carries the app's id and nothing else. Following it shows the app in Hub, on a device that can run it, and the owner installs it there: a link never installs by itself.The page
<a>with that link. The disabled "Not open yet" state is gone, with its string.?or a#would otherwise read as another app's id with a query, which Hub ignores.English and Simplified Chinese both have the new line.
Checked
bun run typecheck:site,bun test ./store/test(two new tests hold the link to the shape Hub takes),bun run site:build.href, the click, the line that follows, the page staying where it is.Before merging
A merge deploys the store. From then on every visitor gets a live button, and until Pocket Hub is released it opens nothing for anyone without a build of it. The line under the button says so, but only after the click. The contract in Hub should be merged first.