Repository navigation
ch4: fix use of builtin_element_size in pack/unpack - #5743
Merged
Merged
Conversation
Collaborator
Author
|
test:mpich/ch4/ofi |
raffenet
approved these changes
Jan 4, 2022
If the datatype is from a flatted type, builtin_element_size can be garbage because the field is not copied in struct flatten_hdr. Obtain the builtin_element_size from basic_type instead.
Add an assertion to check actual_pack_bytes from MPIR_Typerep_pack to catch potential errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
If the datatype is from a flatted type, builtin_element_size can be
garbage because the field is not copied in struct flatten_hdr.
Obtain the builtin_element_size from the basic type instead.
Background:
This bug was not detected in our testsuite because the current (get_acc) tests do not cover the case when a flattened datatype object reuses the previously freed handle memory with non-zero conflicting values of
builtin_element_size. It was caught in #5725 when we test multiple tests within a singleMPI_Init/Finalizewindow.[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.