Skip to content

cronic: turn the caller's verbose off for cronic itself; generate all SHELLOPTS test wrappers with one function - #144

Closed
mernst wants to merge 4 commits into
plume-lib:masterfrom
mernst:cronic-verbose-test-wrappers
Closed

mernst wants to merge 4 commits into
plume-lib:masterfrom
mernst:cronic-verbose-test-wrappers

Conversation

@mernst

@mernst mernst commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

verbose. When the caller's verbose was on (bash -v cronic, or verbose in an exported SHELLOPTS), cronic echoed its entire source to stderr. Now cronic saves and turns off -v along with -a and -x, and restores it for the command. The block that does so is now at the top of the script, because bash echoes each line as it reads it until set +v runs; so under verbose, cronic still echoes its first 6 lines. A new test checks that it echoes nothing more.

Test wrappers. make_cronic_wrapper now also generates the xtrace wrapper, rather than a separate heredoc duplicating it. Every wrapper now unsets BASH_ENV, so that cronic does not run the user's startup file with the exported option on, and discards its own stderr (and so its own trace).

The test that collects the variable names that cronic assigns now also matches an assignment after { .

…he command; tests: generate every SHELLOPTS wrapper with one function, which unsets BASH_ENV
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: plume-lib/plume-scripts/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d7a9eaa3-dd2e-4ca7-9899-180d7c102bfd

📥 Commits

Reviewing files that changed from the base of the PR and between 9f780b8 and 4761b53.


📒 Files selected for processing (2)
  • cronic
  • tests/cronic-test/cronic-test.sh

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst

mernst commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #136, which has the same cronic --help text about not exporting verbose, in the same place, and a more thorough approach to the SHELLOPTS tests.

@mernst mernst closed this Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant