Repository navigation
Conversation
…he command; tests: generate every SHELLOPTS wrapper with one function, which unsets BASH_ENV
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e comment; tests: run the verbose test through `check`
…port it; tests: drop redundant BASH_ENV settings
Contributor
Author
|
Closing in favor of #136, which has the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verbose. When the caller's verbose was on (
bash -v cronic, or verbose in an exported SHELLOPTS), cronic echoed its entire source to stderr. Now cronic saves and turns off-valong with-aand-x, and restores it for the command. The block that does so is now at the top of the script, because bash echoes each line as it reads it untilset +vruns; so under verbose, cronic still echoes its first 6 lines. A new test checks that it echoes nothing more.Test wrappers.
make_cronic_wrappernow also generates the xtrace wrapper, rather than a separate heredoc duplicating it. Every wrapper now unsets BASH_ENV, so that cronic does not run the user's startup file with the exported option on, and discards its own stderr (and so its own trace).The test that collects the variable names that cronic assigns now also matches an assignment after
{.