Repository navigation
Check for predictable temporary file names while cronic runs the command - #131
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mernst
added a commit
to mernst/plume-scripts
that referenced
this pull request
Oct 9, 2026
The wrapped command writes a unique marker, and the test checks that every file containing it is in a private `mktemp -d` directory under $TMPDIR. This detects any predictable naming scheme, avoids false matches of short process ids, reports unsafe files before the vacuity check, tolerates find errors, and lets the wrapped command exit if the test exits early. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temp-file-test.shchecks thatcronic's temporary file names are not derived from its process id. It looked for those names from within the wrapped command, using$PPIDascronic's process id. That check passes vacuously if the wrapped command's parent is notcronicitself (for example, ifcronicruns the command in a subshell), and it never confirmed thatcronichad any temporary files to look at.This pull request:
$TMPDIRand the predictable names under/tmp, usingcronic's own process id;cronichas no temporary files at that time, so that the test cannot pass vacuously;Only the test changes;
cronicdoes not. This is split out of #129.