Skip to content

Update linting settings - #60

Merged
mernst merged 1 commit into
mainfrom
linting4
Aug 8, 2026
Merged

mernst merged 1 commit into
mainfrom
linting4

Conversation

@mernst

@mernst mernst commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated prek.toml exclusions for expected files, project resources, Povray tests, abstract HTML pages, and the publications index. Removed obsolete Povray and JDK exclusions. Added CircleCI validation. Updated Java and Gradle Kotlin file matching for Spotless. Updated Checkmake and Yamllint repository URLs, and upgraded Yamllint to v1.38.0.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch linting4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@prek.toml`:
- Around line 89-99: Provision the CircleCI CLI, including the circleci-validate
tool, in the CI setup before the pre-commit hooks run. Update the workflow’s
installation steps associated with prek so the circleci_validate hook in
prek.toml can execute before validating workflow files, while preserving the
existing prek checks.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 84939b42-0216-4ea8-84c5-97dafd44c110

📥 Commits

Reviewing files that changed from the base of the PR and between e4ec5e9 and e9ee5bd.

📒 Files selected for processing (1)
  • prek.toml

Comment thread prek.toml
Comment on lines +89 to +99
## CircleCI

# This doesn't install the tool! It fails with "Circleci CLI could not be
# found." unless you have installed the CircleCI CLI. Using `snap` to install
# leads to permission problems due to snap confinement. To install:
# - run: curl -fLSs https://raw.githubusercontent.com/CircleCI-Public/circleci-cli/main/install.sh | sudo bash
[[repos]]
repo = "https://github.com/zahorniak/pre-commit-circleci"
rev = "v1.3.0"
hooks = [{ id = "circleci_validate" }]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== candidate files =="
git ls-files | rg '(^|/)prek\.toml$|(^|/)\.circleci/|^\.github/workflows/|(^|/)pre-commit-hooks\.yaml$' || true

echo
echo "== prek.toml relevant lines =="
if [ -f prek.toml ]; then
  nl -ba prek.toml | sed -n '75,110p'
fi

echo
echo "== .circleci tracked? =="
git ls-files .circleci || true

echo
echo "== CircleCI files if any =="
find .circleci -maxdepth 3 -type f 2>/dev/null | sed 's#^\./##' || true

echo
echo "== workflows =="
for f in $(git ls-files '.github/workflows/*'); do
  echo "--- $f"
  nl -ba "$f" | sed -n '1,180p'
done

echo
echo "== hook refs/tests around circleci_validate =="
rg -n "circleci_validate|pre-commit-circleci|CircleCI|\.circleci" -S . --glob '!**/node_modules/**' --glob '!**/.git/**' || true

echo
echo "== remote hook manifest if present in repo/cache? =="
if git ls-files | rg 'pre-commit-circleci/.pre-commit-hooks\.yaml$' >/dev/null; then
  for f in $(git ls-files | rg 'pre-commit-circleci/.pre-commit-hooks\.yaml$'); do
    echo "--- $f"
    nl -ba "$f" | sed -n '1,120p'
  done
else
  echo "repo-local pre-commit-circleci/.pre-commit-hooks.yaml not found"
fi

Repository: plume-lib/git-scripts

Length of output: 319


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== file sizes =="
wc -l prek.toml .github/workflows/prek.yaml .github/workflows/test.yml

echo
echo "== prek.toml relevant lines =="
awk 'NR>=1;NR<=120{printf "%6d  %s\n", NR, $0}' prek.toml | sed -n '75,110p'

echo
echo "== .circleci tracked? =="
git ls-files .circleci || true

echo
echo "== GitHub workflows =="
for f in .github/workflows/prek.yaml .github/workflows/test.yml; do
  echo "--- $f"
  awk 'NR>=1{printf "%6d  %s\n", NR, $0}' "$f"
done

echo
echo "== CircleCI references and CLI installs =="
rg -n "circleci_validate|pre-commit-circleci|CircleCI|\.circleci|circle ci|circleci install|curl .*install\.sh|apt|apk|brew|sudo" -S . --glob '!**/node_modules/**' --glob '!**/.git/**' || true

Repository: plume-lib/git-scripts

Length of output: 3711


🌐 Web query:

https://raw.githubusercontent.com/zahorniak/pre-commit-circleci/v1.3.0/.pre-commit-hooks.yaml

💡 Result:

The file.pre-commit-hooks.yaml is a required configuration file in the pre-commit framework that defines the plugins (hooks) available within a git repository [1][2]. For the repository zahorniak/pre-commit-circleci, this file serves as the manifest that tells the pre-commit framework how to run CircleCI-related tasks [3]. Specifically, in version v1.3.0 of zahorniak/pre-commit-circleci, the.pre-commit-hooks.yaml file defines the interface for the following hooks [3]: circleci_validate: Executes circleci config validate to ensure your CircleCI configuration file is syntactically correct [3]. circleci_process: Executes circleci config process to expand your CircleCI configuration (useful for processing orbs and dynamic configurations) [3]. circleci_pack: Executes circleci config pack to package modular configuration files from a source directory [3]. circleci_pack_validate: Combines packing and validation, typically used for projects utilizing CircleCI dynamic configuration and the continuation orb [3]. By including this file, the repository enables users to integrate these specific CircleCI operations into their local git workflow by adding the repository as a dependency in their own.pre-commit-config.yaml file [3]. The file specifies essential metadata for each hook, including the hook ID, the entry point (the command to execute), and the language (how the hook should be installed and run) [1][2].

Citations:


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== remote hook manifest line 1-120 =="
curl -fsSL -o /tmp/prek-toml-circleci-hooks.yaml 'https://raw.githubusercontent.com/zahorniak/pre-commit-circleci/v1.3.0/.pre-commit-hooks.yaml' || { echo "failed to fetch"; true; }
awk 'NR>=1;NR<=120{printf "%6d  %s\n", NR, $0}' /tmp/prek-toml-circleci-hooks.yaml

echo
echo "== exact circleci_validate hook shape =="
awk '/^- name: circleci_validate/,/^  / || NR==1{print NR, $0}' /tmp/prek-toml-circleci-hooks.yaml | sed -n '1,40p' || true
python3 - <<'PY'
import re, urllib.request
url='https://raw.githubusercontent.com/zahorniak/pre-commit-circleci/v1.3.0/.pre-commit-hooks.yaml'
text=urllib.request.urlopen(url, timeout=10).read().decode()
for i,line in enumerate(text.splitlines(),1):
    if 'circleci_validate' in line:
        start=max(1,i-5); end=i+30
        for n,l in enumerate(text.splitlines()[start-1:end],start):
            print(f"{n:6d} {l}")
PY

Repository: plume-lib/git-scripts

Length of output: 4625


Provision the circleci-validate tool before enabling this hook.

circleci_validate runs circleci-validate, but the workflow only installs prek and has no CircleCI CLI provisioning. CI already checks .github/workflows/prek.yaml, so this hook can pick up workflow files before .circleci exists and fail unless the tool is installed.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@prek.toml` around lines 89 - 99, Provision the CircleCI CLI, including the
circleci-validate tool, in the CI setup before the pre-commit hooks run. Update
the workflow’s installation steps associated with prek so the circleci_validate
hook in prek.toml can execute before validating workflow files, while preserving
the existing prek checks.

@mernst
mernst merged commit 4fda27d into main Aug 8, 2026
5 checks passed
@mernst
mernst deleted the linting4 branch August 8, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant