Skip to content

Fix z-index issue with changelog badges #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cannonb4ll merged 2 commits into from
Sep 28, 2026
Merged

Fix z-index issue with changelog badges #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
026a789
Fix z-index issue with changelog badges
stayallive Sep 28, 2026
f6f49ec
Fixup UI to always be full height on shorter pages
stayallive Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions resources/views/components/app.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function updateTheme() {
<meta name="robots" content="noindex">
@endif
</head>
<body class="antialiased bg-gray-50 dark:bg-gray-950 dark:text-white">
<body class="flex min-h-dvh flex-col antialiased bg-gray-50 dark:bg-gray-950 dark:text-white">
@if($userNeedsToVerify)
<div class="relative bg-brand-600">
<div class="max-w-7xl mx-auto py-3 px-3 sm:px-6 lg:px-8">
Expand All @@ -62,11 +62,11 @@ function updateTheme() {

<livewire:header :logo="$logo" :current-project-id="$currentProjectId" />

<div class="flex mx-auto py-5 lg:space-x-10 h-full px-4 sm:px-6 md:px-8 max-w-[1500px]">
<div class="flex flex-1 w-full mx-auto pt-5 lg:space-x-10 px-4 sm:px-6 md:px-8 max-w-[1500px]">
@include('partials.navbar')

{{-- overflow-x-clip (not hidden) keeps overflow-y visible, so card rings at the bottom aren't cut off. The horizontal padding leaves room for card shadows on the sides. --}}
<main class="flex-1 h-full lg:border-l border-gray-200 px-1 lg:pl-5 dark:lg:border-white/10 overflow-x-clip">
{{-- overflow-x-clip (not hidden) keeps overflow-y visible, so card rings at the bottom aren't cut off. The horizontal and bottom padding leave room for card shadows inside the column. min-w-0 stops wide content (like the board columns) from stretching main, since clip doesn't do that like hidden did. --}}
<main class="flex-1 min-w-0 lg:border-l border-gray-200 px-1 pb-5 lg:pl-5 dark:lg:border-white/10 overflow-x-clip">
<div class="pb-4">
<ul class="flex items-center space-x-0.5 text-sm font-medium text-gray-600 dark:text-gray-500">
@foreach(array_filter($breadcrumbs) as $breadcrumb)
Expand Down
2 changes: 1 addition & 1 deletion resources/views/livewire/changelog/index.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
@foreach($changelogsOnDate as $changelog)
@php($project = $changelog->project?->isVisibleForCurrentUser() ? $changelog->project : null)

<li class="group relative flex flex-col gap-2 p-5 transition hover:bg-gray-50 dark:hover:bg-white/5">
<li class="group relative isolate flex flex-col gap-2 p-5 transition hover:bg-gray-50 dark:hover:bg-white/5">
@if($project || $showAuthor || $groupByMonth)
<div class="flex flex-wrap items-center gap-x-3 gap-y-1">
@if($project)
Expand Down
2 changes: 1 addition & 1 deletion resources/views/partials/navbar.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="hidden lg:block">
<div class="hidden lg:block pb-5">
<aside class="w-60" aria-label="Sidebar">
<div class="overflow-y-auto space-y-4">
<ul class="space-y-2 pb-4 border-b border-gray-200 dark:border-white/10">
Expand Down
Loading