Split the profile page into tabs - #366
Merged
Merged
Conversation
The profile page had grown too long, so it now uses Filament tabs: Account, Preferences, Security (two-factor), MCP access and Social login. The MCP and Social login tabs only show when those features are enabled, and the active tab is kept in the URL. The locale and date locale selects are now searchable. Co-Authored-By: Claude <[email protected]>
overflow-x-hidden on the main element also turns overflow-y into auto, which clipped the ring at the bottom of the last card on a page. overflow-x-clip clips horizontally the same way but leaves the vertical axis visible. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile page had grown too long, so it now uses Filament tabs to separate everything.
Profile tabs
The active tab is kept in the URL (
?tab=security), and "View public profile" and "Logout" now sit above the tabs. The locale and date locale selects are now searchable.Layout fix
The bottom border of the last card on a page was cut off.
overflow-x-hiddenon<main>also turnsoverflow-yintoauto, which clipped the ring Filament uses as the card border.overflow-x-clipclips horizontally the same way but leaves the vertical axis visible.Tests
Added
tests/Feature/Livewire/ProfileTabsTest.php; the existing profile, two-factor and MCP token tests still pass.