Skip to content

Web manifest enhancement - #11

Merged
cehan-Chloe merged 8 commits into
mainfrom
web-manifest-enhancement
Sep 9, 2026
Merged

cehan-Chloe merged 8 commits into
mainfrom
web-manifest-enhancement

Conversation

@cehan-Chloe

@cehan-Chloe cehan-Chloe commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

test result using player's reference-assets running in react repo by updating js_pipeline to js_xlr_pipeline

{
    "pluginName": "reference-assets-web-plugin",
    "capabilities": {
        "Assets": [
            "Assets.InputAsset",
            "Assets.TextAsset",
            "Assets.ActionAsset",
            "Assets.CollectionAsset",
            "Assets.ChoiceAsset"
        ],
        "Views": [
            "Views.InfoAsset"
        ]
    },
    "customPrimitives": [
        "Expression",
        "Asset",
        "Binding",
        "AssetWrapper",
        "Schema.DataType",
        "ExpressionHandler",
        "FormatType",
        "ValidatorFunction"
    ],
    "packages": {
        "react": {
            "name": "@player-ui/reference-assets-plugin-react",
            "version": "1.2.0-next.7"
        }
    }
}

test in npm repo


{
    "pluginName": "'...'",
    "capabilities": {
        "Assets": [],
        "Views": [],
        "Expressions": [],
        "DataTypes": [
            "DataTypes...."
        ],
        "Formatters": [
            "Formatters..."
        ],
        "Validators": [...
        ]
    },
    "customPrimitives": [...
    ],
    "packages": {
        "react": {
            "name": "@date-plugin",
            "version": "5.8.43"
        }
    }
}

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.04545% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.61%. Comparing base (3ccdf97) to head (8f6ec43).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/utils/xlr/packages.ts 94.44% 4 Missing ⚠️
cli/src/commands/xlr/compile.ts 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
+ Coverage   21.91%   33.61%   +11.70%     
===========================================
  Files          26       27        +1     
  Lines        1807     1889       +82     
  Branches       89      140       +51     
===========================================
+ Hits          396      635      +239     
+ Misses       1410     1252      -158     
- Partials        1        2        +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cehan-Chloe
cehan-Chloe marked this pull request as ready for review August 31, 2026 13:59
@cehan-Chloe
cehan-Chloe requested a review from a team as a code owner August 31, 2026 13:59
Comment thread cli/src/commands/xlr/compile.ts Outdated
Comment thread cli/src/commands/xlr/compile.ts Outdated
fs.readFileSync(path.join(packageDir, "package.json"), "utf-8"),
);
} catch {
return undefined;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to log a warning/error here?

Comment thread cli/src/utils/xlr/packages.ts Outdated
* Elsewhere the package manager keeps `package.json` current and it is read directly.
*/

export type WarnFn = (message: string) => void;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to redefine this or can we use the type from oclif?

Comment thread package.json
Comment on lines +26 to +29
"@xlr-lib/xlr": "1.1.0-next.0",
"@xlr-lib/xlr-converters": "1.1.0-next.0",
"@xlr-lib/xlr-sdk": "1.1.0-next.0",
"@xlr-lib/xlr-utils": "1.1.0-next.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure to update these versions before the next release

@cehan-Chloe
cehan-Chloe merged commit 2a74dd1 into main Sep 9, 2026
8 checks passed
@KetanReddy KetanReddy added the minor Increment the minor version when merged label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants