Skip to content

MILAB-7194: store picked columns as ids and gates and conditions as column value references - #16

Merged
AStaroverov merged 17 commits into
mainfrom
MILAB-7194_column-value-refs
Nov 6, 2026
Merged

AStaroverov merged 17 commits into
mainfrom
MILAB-7194_column-value-refs

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The block stores the columns it picks as result-pool column ids and the gates and conditions it picks as column value references of the gate and condition columns, so the metadata block knows which of its values this block uses and a missing pick is explained in place. Behaviour is unchanged otherwise: every check that disables the run stays.

  • Columns. The dataset with its optional subset, and the condition, gate and sort-fraction columns are result-pool ids, found through ColumnsCollection(["result_pool"]) / deriveColumnOptions. PlDatasetSelector still speaks PlRef, so the stored ids are converted for it and back.
  • Picked values. gateOrder, inputGate and excludedConditions are ColumnValueIds. The ranks the workflow receives are keyed by the same ids.
  • Value options. The model gives createColumnValueOptions for every metadata column on offer, and the settings panel reads them with readColumnValueOptions. All offered columns are read up front, so a pick writes the value snapshot and seeds the gate order in the same click; no watcher writes block data. The run statistics take the sample names from the model (deriveAxisValuesLabels).
  • Value snapshots. gateValues and conditionValues are kept as ColumnValueId[], so the checks against them stay: a gate column with no values, a gate or an input the gate column does not carry, and every condition excluded still disable the run. The unsorted input is offered from the snapshot, as on main. A pick missing from the column shows as not available, with a tooltip naming the block that was to provide it.
  • Run gate. argsIssues reports every check that disables the run; the args lambda no longer throws.
  • Kind. Column params are accepted only as result-pool ids of other blocks' outputs (isGlobalPObjectId), values as ColumnValueIds. Templates made for the earlier kind cannot be applied.
  • Migration. Step Ver_2026_10_21 converts the stored dataset and subset refs to ids and clears the anchored condition, gate and sort-fraction columns with the values picked in them and their snapshots. Major bump.
  • Workflow. Column resolution is as on main: the ids are json.decoded where a ref is needed, metadata columns come through the bundle by id, picked values are unwrapped with columnValue.valueOf and passed to the software as text.
  • Deprecated API. 14 uses in the model before, 0 after; PlMaskIcon24 replaced by PlIcon24.
  • SDK. model / ui-vue 1.88.0, workflow-tengo 6.20.0; vue 3.5.44 and @milaboratories/helpers 1.14.6, which that SDK requires.

Checked: forced build 12/12, kind tests 44, model tests 37, software tests 250. Not run: a run on a live backend.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no new actionable defect was established.

Summary

The PR stores picked columns as result-pool IDs and picked values as column value IDs. The workflow unwraps those values before passing them to the computation.

  • Saved column picks now name the block that provides each column.
  • Picked values that disappear from a column stay visible as unavailable.
  • The workflow turns picked value references into the text the scorer uses.
  • Run statistics now get sample names from the model.
  • The project updates its SDK tools and test setup.

Important touched types:

  • ColumnUniversalId: identifies a column. Stored dataset, subset, and metadata picks now use result-pool IDs.
  • ColumnValueId: identifies a value and the column it came from. Gate order, input, exclusions, and snapshots now use these IDs.
  • BlockData: holds saved settings and view state. Its picks use the new IDs.
  • BlockArgs: holds workflow inputs. Column fields can be absent while setup is incomplete; gate ranks are keyed by value IDs.
  • ColumnValueOptionsModel: tells the UI where to read a column’s values. The model now supplies one for every offered metadata column and saved gate or condition pick.
  • ColumnValueOptionsState: tracks whether a UI value read is loading, absent, complete, or failed.
  • AbundancePick: pairs the saved dataset and optional subset IDs for conversion to and from the dataset picker.

No build, tests, or browser checks were run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Dataset picker] --> B[Saved column IDs]
  C[Metadata value sources] --> D[UI reads value options]
  D --> E[Saved column value IDs]
  B --> F[BlockArgs]
  E --> F
  F --> G[Workflow resolves columns]
  G --> H[Workflow unwraps picked values]
  H --> I[Sort-seq computation]
Loading

Reviews (4) · Last reviewed commit: "MILAB-7194: keep in the migration only t..." · Reviewed by Greptile

Comment thread ui/src/components/SettingsDrawer.vue Resolved
@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

Comment thread ui/src/components/SettingsDrawer.vue Resolved
@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

…h frames

args() builds args from whatever is configured and argsIssues() says what keeps the block from
running, so the app sees the columns the block references while it is still being set up.

The metadata values and the sample names are read in the UI, through a frame of each column, so
a column of any storage format can be picked from; a column that is gone or cannot be read says
why under its picker.
@AStaroverov
AStaroverov force-pushed the MILAB-7194_column-value-refs branch from d991e5f to 3ce06c6 Compare November 4, 2026 08:55
@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was skipped because it would exceed your organization's monthly flex usage limit. Raise the limit in billing settings or wait until the next billing period resets limits.

@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

…t a dataset

A block made from a template has its gates and conditions but no dataset, so its picks were never checked against the column and never shown as not available.
@greptile-apps

greptile-apps Bot commented Nov 5, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@AStaroverov
AStaroverov added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 677ace3 Nov 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant