Repository navigation
Compute the block subtitle's settings part in the model - #58
Merged
Merged
Conversation
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Only the subtitle was affected. A
watchEffectin the main page wrotedata.defaultBlockLabel: on the file door<file label>[ - <scheme>](scheme only when not IMGT), on the dataset door<pool dataset label> - <chains>. It fed only.subtitle, never args, so opening the UI did not make the block stale. But a block set up without opening the UI (e.g. from a template) had an empty subtitle until someone opened it.The trace labels were already pure functions of args, named after what was imported (the file source's label, the chain or receptor, the format), and are unchanged.
Change
customBlockLabelstays out of args, so renaming the block still does not make it stale.customBlockLabel, else[subtitleLabel, settings].join(" - "). The settings part is computed in the model: on the file door the file label plus the numbering scheme when not IMGT, on the dataset door the chains joined by ", ".subtitleLabelholds the picked pool dataset's label (empty on the file door), kept in sync with the result pool by a guarded watch in app setup; it writes only when the label changes and never reaches args. The main page'swatchEffectand the "Select Dataset" seed on load are removed.defaultBlockLabelmixed the dataset name with the chains and cannot be split without the pool, sosubtitleLabelstarts empty; the file-door subtitle is fully recomputed from data.defaultBlockLabelwas never part of the contract); no version bump.subtitleLabelinstead ofdefaultBlockLabel.IGHeavy(chain step),MiXCR bulk(stats step)Donor 3, IGHeavy + IGLightDonor 3 - IGHeavy, IGLightDonor 3 - IGHeavy, IGLightIGHeavy, IGLightpanel, Kabatpanel - Kabat(only after opening)panel - KabatImpact
IGHeavy, IGLight) until the block is opened; file-door blocks keep their subtitle.Verification