Repository navigation
Conversation
Contributor
Author
| ### What is the secondary count type for? | ||
|
|
||
| Some pipelines report both read counts and UMI counts. Configure the primary count type you want abundances based on, and carry the other as a secondary count so both remain available downstream. | ||
| Some pipelines report both read counts and UMI counts. In Custom mode, set the primary count type you want abundances based on, and carry the other as a secondary count so both remain available downstream. Recognized formats carry every count they have and base abundances on UMIs when present. |
There was a problem hiding this comment.
README.md promises that recognized formats keep every count, but immunoSEQ builds one read-count: it uses templates when filled and otherwise reads. It also sets hasUMIs to false. Users may expect both source counts downstream, but this preset keeps only one. Document immunoSEQ’s one-count exception here and in the overview.
Knowledge Base Used: Source format and column inference
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 57
Comment:
**Count retention is overstated**
`README.md` promises that recognized formats keep every count, but immunoSEQ builds one `read-count`: it uses `templates` when filled and otherwise `reads`. It also sets `hasUMIs` to false. Users may expect both source counts downstream, but this preset keeps only one. Document immunoSEQ’s one-count exception here and in the overview.
**Knowledge Base Used:** [Source format and column inference](https://app.greptile.com/milaboratories/-/custom-context/knowledge-base/platforma-open/import-vdj-data/-/docs/source-format-and-column-inference.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
Author
There was a problem hiding this comment.
README reverted to previous state in c1284da
Contributor
Author
julenmendieta
requested changes
Nov 16, 2026
julenmendieta
left a comment
Contributor
There was a problem hiding this comment.
I shared a document with some issues I found, and that need to be adressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Confidence Score: 5/5
The PR appears safe to merge; the remaining documentation issue is non-blocking.Fix with agent prompt
Summary
Reworks format imports, chain pairing, and import statistics.
Important touched types:
BlockArgs: Settings sent to the workflow. Single-cell selections now include partner chains;primaryCountTypeis sent only for Custom imports.BlockData: Saved settings and table state. Existing table layouts reset once to use the new column defaults.BareSetMapping: Maps named records to chain sequences and optional genes. New blocks remove mappings for undeclared chains.AssemblingFeature: Names the sequence region used to group clonotypes. MiXCR now supports an explicit choice alongside AIRR.MappableColumn: Describes a Custom mapping control. Its new optionalrequiredfield lets either CDR3 sequence satisfy the sequence requirement.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Source tables] --> B[Infer columns] B --> C[Apply format rules] C --> D[Count discarded rows] C --> E{Import mode} E --> F[Bulk clonotypes] E --> G[Pair cell chains] E --> H[Annotate named records] F --> I[Dataset and statistics] G --> I H --> IReviews (3) · Last reviewed commit: "MILAB-6935: restore the README count par..." · Reviewed by Greptile