Skip to content

MILAB-7194: warn about blocks missing data of this block - #55

Merged
AStaroverov merged 7 commits into
mainfrom
MILAB-7194_column-value-refs
Nov 6, 2026
Merged

AStaroverov merged 7 commits into
mainfrom
MILAB-7194_column-value-refs

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

The block warns when blocks below it use its data and that data is gone or not produced yet, and keeps its own link to the dataset it reads while it is being set up.

  • UI (ui/src/pages/MainPage.vue, the block's only page): <PlBlockDependencies />. It reads the column links the app computes and shows nothing while every link is fine. When another block uses an output this block does not export, values this block no longer has, or data of this block before it has been run, it shows a warning naming those blocks, with advice to add the missing data or run the block; block names open the block.
  • Model (model/src/index.ts): the block reads a Samples & Data dataset (datasetRef), so it is also a consumer. The checks moved from a throw in args() to argsIssues(), in the same order with the same messages, so Run stays disabled exactly when it did before. args() now always builds args, so a block not yet run keeps its reference to the dataset: Samples & Data lists it among the blocks using its data, and its own alert sees the dataset. datasetRef stays a PlRef, which the app already reads as a column reference.
  • SDK. model / ui-vue 1.88.0, workflow-tengo 6.20.0; vue 3.5.44 and @milaboratories/helpers 1.14.6, which that SDK requires. One file is reformatted for the newer oxfmt.

Checked: forced build 14/14, model tests 15 (every former refusal, args with only a dataset picked, both runnable paths), kind tests 64, tengo tests 57. Not run: the block tests on a live backend.

RetriggerView in GreptileConfidence Score: 5/5

No confirmed issue blocks merging this PR.

Summary

Adds warnings for downstream blocks that need missing import data. Keeps the selected dataset reference available while setup is unfinished.

  • The import keeps its dataset link while setup is still in progress.
  • The import page shows warnings when downstream blocks lose data they use.
  • The block packages use updated shared SDK versions.

Important touched types:

  • ArgsIssue: an SDK type describing a problem with block arguments. Newly used to return the first error that prevents a run.
  • BlockArgs: the values sent to the workflow. Its shape is unchanged; the model now builds it before setup is complete.
  • BlockData: the block’s saved settings and view state. Its shape is unchanged; prerunCheck now feeds the separate run check.
  • PlRef: a reference to another block’s output. datasetRef keeps this type and remains in unfinished args so the app can track the link.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Saved settings] --> B[projectArgs]
  A --> C[runRefusal]
  B --> D[Args retain selected dataset reference]
  C --> E[argsIssues]
  E --> F[Run checks]
  D --> G[App tracks block links]
  G --> H[PlBlockDependencies shows warnings]
Loading

Reviews (3) · Last reviewed commit: "MILAB-7194: describe the model change in..." · Reviewed by Greptile

@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

args() builds args from whatever is configured and argsIssues() says what keeps the import from running, with the same checks in the same order and the same messages. A dataset picked while the import is still being set up is then part of the args, so the block keeps its link to the block that produced the dataset.
@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

… test

The args are now built and the run is refused with the check's own message, not for missing args.
@greptile-apps

greptile-apps Bot commented Nov 5, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@AStaroverov
AStaroverov added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit c238082 Nov 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant