Repository navigation
MILAB-7194: warn about blocks missing data of this block - #55
Merged
Merged
Conversation
Contributor
Author
args() builds args from whatever is configured and argsIssues() says what keeps the import from running, with the same checks in the same order and the same messages. A dataset picked while the import is still being set up is then part of the args, so the block keeps its link to the block that produced the dataset.
Contributor
Author
… test The args are now built and the run is refused with the check's own message, not for missing args.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block warns when blocks below it use its data and that data is gone or not produced yet, and keeps its own link to the dataset it reads while it is being set up.
ui/src/pages/MainPage.vue, the block's only page):<PlBlockDependencies />. It reads the column links the app computes and shows nothing while every link is fine. When another block uses an output this block does not export, values this block no longer has, or data of this block before it has been run, it shows a warning naming those blocks, with advice to add the missing data or run the block; block names open the block.model/src/index.ts): the block reads a Samples & Data dataset (datasetRef), so it is also a consumer. The checks moved from a throw inargs()toargsIssues(), in the same order with the same messages, so Run stays disabled exactly when it did before.args()now always builds args, so a block not yet run keeps its reference to the dataset: Samples & Data lists it among the blocks using its data, and its own alert sees the dataset.datasetRefstays aPlRef, which the app already reads as a column reference.@milaboratories/helpers1.14.6, which that SDK requires. One file is reformatted for the newer oxfmt.Checked: forced build 14/14, model tests 15 (every former refusal, args with only a dataset picked, both runnable paths), kind tests 64, tengo tests 57. Not run: the block tests on a live backend.


Confidence Score: 5/5
No confirmed issue blocks merging this PR.Summary
Adds warnings for downstream blocks that need missing import data. Keeps the selected dataset reference available while setup is unfinished.
Important touched types:
ArgsIssue: an SDK type describing a problem with block arguments. Newly used to return the first error that prevents a run.BlockArgs: the values sent to the workflow. Its shape is unchanged; the model now builds it before setup is complete.BlockData: the block’s saved settings and view state. Its shape is unchanged;prerunChecknow feeds the separate run check.PlRef: a reference to another block’s output.datasetRefkeeps this type and remains in unfinished args so the app can track the link.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Saved settings] --> B[projectArgs] A --> C[runRefusal] B --> D[Args retain selected dataset reference] C --> E[argsIssues] E --> F[Run checks] D --> G[App tracks block links] G --> H[PlBlockDependencies shows warnings]Reviews (3) · Last reviewed commit: "MILAB-7194: describe the model change in..." · Reviewed by Greptile