Skip to content

By sample: pick several samples and export the table on screen - #53

Draft
AStaroverov wants to merge 1 commit into
mainfrom
feat/by-sample-multiselect-export
Draft

AStaroverov wants to merge 1 commit into
mainfrom
feat/by-sample-multiselect-export

Conversation

@AStaroverov

Copy link
Copy Markdown
Contributor

The By sample table lets the user pick several samples, or all of them, on its sheet. Export writes exactly the table on screen. The export dialog and its own sample selection are gone.

Depends on milaboratory/platforma#1992 (multi-value sheets, fixedFilters, fixedSorting in createPlDataTableV3). Draft until that is released.

What changes

By sample table (sampleTable):

  • The sheet is createPlDataTableSheet(..., { selection: "multiple" }).
  • fixedSorting by the sample axis, ascending, keeps each sample's rows together. The user's sorting orders rows within a sample.
  • The table is always built from discoverTableColumnSnaphots primary columns, with or without a subset. That adds a label column for every axis, so each row names its sample while several are shown, on screen and in the export.

Subset filter (Overlap and By sample): passed as fixedFilters instead of being written into the table state on every render. The withSubsetFilter / dropSampleSheetFilter / andFilter helpers are gone.

Export:

  • The Export button writes the on-screen sampleTable through exportSampleTable. It is enabled once that output is ready and has a visible table.
  • An error shows in a PlAlert.
  • Removed: the sampleExportTable output, SampleExportModal.vue, SampleExportSelection.

Block data: a new migration Ver_2026_11_11 drops sampleExport, and init no longer writes it.

Before marking ready

  • Bump @platforma-sdk/model and @platforma-sdk/ui-vue in the catalog to the release that has #1992, plus @milaboratories/helpers (1.14.7 or later) and @milaboratories/pl-model-common to match.
  • Bump @platforma-sdk/block-tools to the latest (2.17.1 → 2.19.1 at the time of writing), which block CI requires.
  • Regenerate pnpm-lock.yaml.
  • Type-check, build and try in the app. This branch has not been built against the final SDK yet.

…screen

The By sample sheet takes several samples, or all of them, and keeps each
sample's rows together. Export writes the table as shown, so the export
dialog, its selection in the block data and its separate table are gone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant