Repository navigation
Milab 7197 add filtered inputs - #49
Merged
Merged
Conversation
Comment on lines
+98
to
+101
| if !is_undefined(inputs.subset) { | ||
| cut := restrictToSubset([annotationsColumn] + filtersColumns, inputs.subset, inputs.subsetId) | ||
| annotationsColumn = cut[0] | ||
| filtersColumns = cut[1:] |
There was a problem hiding this comment.
The new subset export path has no active tests. Exports cut the computed columns, while statistics apply the subset separately. A change could make them disagree without failing checks: the existing workflow test is disabled, and the test command permits an empty suite.
Add a small dataset test with two disjoint subsets, an empty subset, and an unfiltered run. Check exported annotation keys, per-label columns, retained metadata, and matching statistics totals.
Prompt To Fix With AI
This is a comment left during a code review.
Path: workflow/src/annotations.lib.tengo
Line: 98-101
Comment:
**Subset exports lack tests**
The new subset export path has no active tests. Exports cut the computed columns, while statistics apply the subset separately. A change could make them disagree without failing checks: the existing workflow test is disabled, and the test command permits an empty suite.
Add a small dataset test with two disjoint subsets, an empty subset, and an unfiltered run. Check exported annotation keys, per-label columns, retained metadata, and matching statistics totals.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR appears safe to merge, with non-blocking feedback to test the new subset output paths.
Fix with agent prompt
Summary
Adds optional subset selection alongside the input dataset.
Important touched terms:
BlockParams: Inputs used to create a block. Adds optionalfilterRef, with column-ID checks.BlockData: Saved browser state. Adds optionalfilterRefalongsideinputAnchor.BlockArgs: Values sent to the workflow. Adds optionalinputFiltercontaining the subset column ID.DatasetOption: A dataset choice with related subset choices. Replaces the previous flat input options.DatasetSelection: The dataset and optional subset chosen in Settings. The UI converts both references into saved column IDs.ColumnRecipe: A column used to build a table. The selected subset becomes a hidden column used to restrict rows.PlDataTableStateV2: Saved table settings. The model adds the subset condition when building tables.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD Settings[Dataset and optional subset] --> State[Saved inputAnchor and filterRef] State --> Tables[Overlap and By sample tables] State --> Export[By sample export] State --> Rules[Compute annotations on full dataset] Rules --> Stats[Join subset for statistics] Rules --> Cut[Cut published columns to subset] Cut --> Metadata[Add subset domain and trace]Reviews (1) · Last reviewed commit: "MILAB-7197: reuse the prerun annotations..." · Reviewed by Greptile