Skip to content

Milab 7197 add filtered inputs - #49

Merged
mzueva merged 6 commits into
mainfrom
MILAB-7197_add-filtered-inputs
Oct 28, 2026
Merged

mzueva merged 6 commits into
mainfrom
MILAB-7197_add-filtered-inputs

Conversation

@mchernys

@mchernys mchernys commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with non-blocking feedback to test the new subset output paths.

Fix All in Claude CodeFindings

  1. P2 Subset exports lack tests ▶
Fix with agent prompt
### Issue 1
workflow/src/annotations.lib.tengo:98-101
The new subset export path has no active tests. Exports cut the computed columns, while statistics apply the subset separately. A change could make them disagree without failing checks: the existing workflow test is disabled, and the test command permits an empty suite.

Add a small dataset test with two disjoint subsets, an empty subset, and an unfiltered run. Check exported annotation keys, per-label columns, retained metadata, and matching statistics totals.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds optional subset selection alongside the input dataset.

  • Settings lets users pair a dataset with a clonotype subset.
  • Annotations and stats now describe only the selected clonotypes.
  • Build and release setup changes while browser behavior stays the same.

Important touched terms:

  • BlockParams: Inputs used to create a block. Adds optional filterRef, with column-ID checks.
  • BlockData: Saved browser state. Adds optional filterRef alongside inputAnchor.
  • BlockArgs: Values sent to the workflow. Adds optional inputFilter containing the subset column ID.
  • DatasetOption: A dataset choice with related subset choices. Replaces the previous flat input options.
  • DatasetSelection: The dataset and optional subset chosen in Settings. The UI converts both references into saved column IDs.
  • ColumnRecipe: A column used to build a table. The selected subset becomes a hidden column used to restrict rows.
  • PlDataTableStateV2: Saved table settings. The model adds the subset condition when building tables.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Settings[Dataset and optional subset] --> State[Saved inputAnchor and filterRef]
  State --> Tables[Overlap and By sample tables]
  State --> Export[By sample export]
  State --> Rules[Compute annotations on full dataset]
  Rules --> Stats[Join subset for statistics]
  Rules --> Cut[Cut published columns to subset]
  Cut --> Metadata[Add subset domain and trace]
Loading

Reviews (1) · Last reviewed commit: "MILAB-7197: reuse the prerun annotations..." · Reviewed by Greptile

Comment on lines +98 to +101
if !is_undefined(inputs.subset) {
cut := restrictToSubset([annotationsColumn] + filtersColumns, inputs.subset, inputs.subsetId)
annotationsColumn = cut[0]
filtersColumns = cut[1:]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Subset exports lack tests

The new subset export path has no active tests. Exports cut the computed columns, while statistics apply the subset separately. A change could make them disagree without failing checks: the existing workflow test is disabled, and the test command permits an empty suite.

Add a small dataset test with two disjoint subsets, an empty subset, and an unfiltered run. Check exported annotation keys, per-label columns, retained metadata, and matching statistics totals.

Prompt To Fix With AI
This is a comment left during a code review.
Path: workflow/src/annotations.lib.tengo
Line: 98-101

Comment:
**Subset exports lack tests**

The new subset export path has no active tests. Exports cut the computed columns, while statistics apply the subset separately. A change could make them disagree without failing checks: the existing workflow test is disabled, and the test command permits an empty suite.

Add a small dataset test with two disjoint subsets, an empty subset, and an unfiltered run. Check exported annotation keys, per-label columns, retained metadata, and matching statistics totals.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

@mzueva
mzueva merged commit 5b94f92 into main Oct 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants