Repository navigation
feat(dl): segmented multi-connection downloads #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
QaidVoid
wants to merge
5
commits into
main
Choose a base branch
from
segmented-downloads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1339260
feat(dl): segmented multi-connection downloads
QaidVoid 57c2234
fix(dl): harden segmented downloads and resume
QaidVoid 3e22345
fix(dl): validate resume plan before probing
QaidVoid e415cf3
fix(dl): address segmented download review findings
QaidVoid e355881
fix(dl): respect server cooldown across retries
QaidVoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: pkgforge/soar
Length of output: 7856
Script executed:
Repository: pkgforge/soar
Length of output: 8336
Script executed:
Repository: pkgforge/soar
Length of output: 5866
Script executed:
Repository: pkgforge/soar
Length of output: 3073
Script executed:
Repository: pkgforge/soar
Length of output: 1535
Pass the connection count to OCI digest downloads.
soar dl --connections 1 --ghcrdoes not limit a digest-addressed blob to one connection.handle_oci_downloadnever passesctx.connectionstoOciDownload.download_blobthen builds aDownloadwith its default of 8 connections, so a range-capable blob of at least 8 MiB can use segmented requests. Add aconnectionsfield toOciDownload, set it from the context, and forward it indownload_blob.Suggested fix
// crates/soar-cli/src/download.rs, handle_oci_download let mut dl = OciDownload::new(reference) .filter(ctx.create_filter()) .parallel(get_config().ghcr_concurrency.unwrap_or(8)) - .overwrite(ctx.get_overwrite_mode()); + .overwrite(ctx.get_overwrite_mode()) + .connections(ctx.connections); // crates/soar-dl/src/oci.rs, struct OciDownload parallel: usize, + connections: usize, on_progress: Option<Arc<dyn Fn(Progress) + Send + Sync>>, // crates/soar-dl/src/oci.rs, OciDownload::new parallel: 1, + connections: 8, on_progress: None, // crates/soar-dl/src/oci.rs, new setter placed before `api` } + /// Sets how many connections each blob download may open at once. + pub fn connections(mut self, connections: usize) -> Self { + self.connections = connections.max(1); + self + } + /// Sets the base API URL used for manifest and blob requests and returns the downloader for chaining. // crates/soar-dl/src/oci.rs, download_blob let dl = Download::new(url) .output(output.to_string_lossy()) .overwrite(self.overwrite) - .ghcr_blob(); + .ghcr_blob() + .connections(self.connections);