refactor!: drop build log fields and keep typed package errors

crates/soar-core/src/database/models.rs

@@ -55,10 +55,6 @@ pub struct Package {
     pub build_id: Option<String>,
     pub build_date: Option<String>,
     pub build_action: Option<String>,
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_script: Option<String>,
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_log: Option<String>,
     pub provides: Option<Vec<PackageProvide>>,
     pub snapshots: Option<Vec<String>>,
     pub repology: Option<Vec<String>>,
@@ -261,7 +257,6 @@ impl From<soar_db::repository::core::InstalledPackage> for InstalledPackage {
 
 /// Conversion from soar-db metadata Package to soar-core Package.
 impl From<soar_db::models::metadata::Package> for Package {
-    #[allow(deprecated)]
     fn from(pkg: soar_db::models::metadata::Package) -> Self {
         Self {
             id: pkg.id as u64,
@@ -294,8 +289,6 @@ impl From<soar_db::models::metadata::Package> for Package {
             build_id: pkg.build_id,
             build_date: pkg.build_date,
             build_action: pkg.build_action,
-            build_script: pkg.build_script,
-            build_log: pkg.build_log,
             provides: pkg.provides,
             snapshots: pkg.snapshots,
             repology: None,

crates/soar-db/migrations/metadata/2026-10-19-000200-0000_drop_build_fields/down.sql

@@ -0,0 +1,2 @@
+ALTER TABLE packages ADD COLUMN build_script TEXT;
+ALTER TABLE packages ADD COLUMN build_log TEXT;

crates/soar-db/migrations/metadata/2026-10-19-000200-0000_drop_build_fields/up.sql

@@ -0,0 +1,2 @@
+ALTER TABLE packages DROP COLUMN build_script;
+ALTER TABLE packages DROP COLUMN build_log;

crates/soar-db/src/connection.rs

@@ -391,6 +391,39 @@ mod tests {
         assert_eq!(to_maintainers.n, 1);
     }
 
+    #[test]
+    fn upgrading_metadata_drops_build_fields_and_keeps_packages() {
+        let dir = tempfile::tempdir().unwrap();
+        let path = dir.path().join("repo.db");
+        {
+            // The schema as it stood before the build fields were dropped.
+            let mut conn = SqliteConnection::establish(path.to_str().unwrap()).unwrap();
+            for _ in 0..5 {
+                conn.run_next_migration(METADATA_MIGRATIONS).unwrap();
+            }
+            sql_query(
+                "INSERT INTO packages (pkg_name, version, download_url, build_log) \
+                 VALUES ('p', '1', 'https://x', 'https://log')",
+            )
+            .execute(&mut conn)
+            .unwrap();
+        }
+
+        let mut db = DbConnection::open(&path, DbType::Metadata).unwrap();
+        let conn = db.conn();
+        let packages = sql_query("SELECT count(*) AS n FROM packages")
+            .get_result::<Count>(conn)
+            .unwrap();
+        assert_eq!(packages.n, 1, "upgrading lost a package");
+        let build_columns = sql_query(
+            "SELECT count(*) AS n FROM pragma_table_info('packages') \
+             WHERE name IN ('build_script', 'build_log')",
+        )
+        .get_result::<Count>(conn)
+        .unwrap();
+        assert_eq!(build_columns.n, 0);
+    }
+
     #[test]
     fn readonly_opens_a_path_with_uri_characters() {
         let dir = tempfile::tempdir().unwrap();

crates/soar-db/src/models/metadata.rs

@@ -35,10 +35,6 @@ pub struct Package {
     pub build_id: Option<String>,
     pub build_date: Option<String>,
     pub build_action: Option<String>,
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_script: Option<String>,
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_log: Option<String>,
     pub provides: Option<Vec<PackageProvide>>,
     pub snapshots: Option<Vec<String>>,
     pub replaces: Option<Vec<String>>,
@@ -80,8 +76,6 @@ impl Queryable<packages::SqlType, Sqlite> for Package {
         Option<String>,
         Option<String>,
         Option<String>,
-        Option<String>,
-        Option<String>,
         Option<Value>,
         Option<Value>,
         Option<Value>,
@@ -92,7 +86,6 @@ impl Queryable<packages::SqlType, Sqlite> for Package {
         Option<Value>,
     );
 
-    #[allow(deprecated)]
     fn build(row: Self::Row) -> diesel::deserialize::Result<Self> {
         Ok(Self {
             id: row.0,
@@ -121,16 +114,14 @@ impl Queryable<packages::SqlType, Sqlite> for Package {
             build_id: row.23,
             build_date: row.24,
             build_action: row.25,
-            build_script: row.26,
-            build_log: row.27,
-            provides: json_vec!(row.28),
-            snapshots: json_vec!(row.29),
-            replaces: json_vec!(row.30),
-            soar_syms: row.31,
-            desktop_integration: row.32,
-            portable: row.33,
-            extra: json_vec!(row.34),
-            files: json_vec!(row.35),
+            provides: json_vec!(row.26),
+            snapshots: json_vec!(row.27),
+            replaces: json_vec!(row.28),
+            soar_syms: row.29,
+            desktop_integration: row.30,
+            portable: row.31,
+            extra: json_vec!(row.32),
+            files: json_vec!(row.33),
         })
     }
 }
@@ -222,10 +213,6 @@ pub struct NewPackage<'a> {
     pub build_id: Option<&'a str>,
     pub build_date: Option<&'a str>,
     pub build_action: Option<&'a str>,
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_script: Option<&'a str>,
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_log: Option<&'a str>,
     pub provides: Option<Value>,
     pub snapshots: Option<Value>,
     pub replaces: Option<Value>,

crates/soar-db/src/repository/metadata.rs

@@ -631,7 +631,6 @@ impl MetadataRepository {
     /// Inserts a single remote package.
     /// Returns whether the package was accepted; rejected entries are skipped
     /// rather than failing the whole import.
-    #[allow(deprecated)]
     fn insert_remote_package(
         conn: &mut SqliteConnection,
         package: &RemotePackage,
@@ -706,8 +705,6 @@ impl MetadataRepository {
             build_id: package.build_id.as_deref(),
             build_date: package.build_date.as_deref(),
             build_action: package.build_action.as_deref(),
-            build_script: package.build_script.as_deref(),
-            build_log: package.build_log.as_deref(),
             provides: Some(json!(provides)),
             snapshots: Some(json!(package.snapshots)),
             replaces: Some(json!(package.replaces)),

crates/soar-db/src/schema/metadata.rs

@@ -42,8 +42,6 @@ diesel::table! {
         build_id -> Nullable<Text>,
         build_date -> Nullable<Text>,
         build_action -> Nullable<Text>,
-        build_script -> Nullable<Text>,
-        build_log -> Nullable<Text>,
         provides -> Nullable<Jsonb>,
         snapshots -> Nullable<Jsonb>,
         replaces -> Nullable<Jsonb>,

crates/soar-package/src/error.rs

@@ -29,9 +29,13 @@ pub enum PackageError {
     #[diagnostic(code(soar_package::appimage))]
     AppImageError(#[from] squishy::error::SquishyError),
 
-    #[error("Configuration error: {0}")]
-    #[diagnostic(code(soar_package::config))]
-    ConfigError(String),
+    #[error(transparent)]
+    #[diagnostic(transparent)]
+    Config(#[from] soar_config::error::ConfigError),
+
+    #[error(transparent)]
+    #[diagnostic(transparent)]
+    FileSystem(#[from] soar_utils::error::FileSystemError),
 
     #[error("{0}")]
     #[diagnostic(code(soar_package::custom))]
@@ -63,14 +67,39 @@ impl<T> ErrorContext<T> for std::io::Result<T> {
     }
 }
 
-impl From<soar_config::error::ConfigError> for PackageError {
-    fn from(err: soar_config::error::ConfigError) -> Self {
-        PackageError::ConfigError(err.to_string())
+#[cfg(test)]
+mod tests {
+    use std::error::Error as _;
+
+    use super::*;
+
+    #[test]
+    fn a_filesystem_error_keeps_its_cause_and_help() {
+        let err = PackageError::from(soar_utils::error::FileSystemError::ReadFile {
+            path: "/x/y".into(),
+            source: std::io::Error::from(std::io::ErrorKind::PermissionDenied),
+        });
+
+        assert_eq!(err.to_string(), "Failed to read file '/x/y'");
+        assert_eq!(
+            err.source().map(ToString::to_string).as_deref(),
+            Some("permission denied")
+        );
+        assert!(err.help().is_some());
+        assert_eq!(
+            err.code().map(|code| code.to_string()).as_deref(),
+            Some("soar_utils::fs::read_file")
+        );
     }
-}
 
-impl From<soar_utils::error::FileSystemError> for PackageError {
-    fn from(err: soar_utils::error::FileSystemError) -> Self {
-        PackageError::Custom(err.to_string())
+    #[test]
+    fn a_config_error_keeps_its_own_diagnostic() {
+        let err = PackageError::from(soar_config::error::ConfigError::Custom("bad".into()));
+
+        assert_eq!(err.to_string(), "bad");
+        assert_eq!(
+            err.code().map(|code| code.to_string()).as_deref(),
+            Some("soar_config::custom")
+        );
     }
 }

crates/soar-package/src/formats/common.rs

@@ -421,8 +421,7 @@ pub fn create_portable_link<P: AsRef<Path>>(
             "refusing to create portable link with unsafe package name: {pkg_name}"
         )));
     }
-    let base_dir = env::current_dir()
-        .map_err(|_| PackageError::Custom("Error retrieving current directory".into()))?;
+    let base_dir = env::current_dir().with_context(|| "retrieving current directory".into())?;
     let portable_path = portable_path.as_ref();
     let portable_path = if portable_path.is_absolute() {
         portable_path

crates/soar-registry/src/error.rs

@@ -69,14 +69,6 @@ pub enum RegistryError {
     )]
     MetadataTooShort,
 
-    #[error("ETag not found in metadata response")]
-    #[diagnostic(
-        code(soar_registry::missing_etag),
-        help("The server did not return an ETag header")
-    )]
-    #[deprecated(note = "a response without an ETag is accepted and refetched next sync")]
-    MissingEtag,
-
     #[error("Insecure repository URL: {0}")]
     #[diagnostic(
         code(soar_registry::insecure_url),

crates/soar-registry/src/package.rs

@@ -198,14 +198,6 @@ pub struct RemotePackage {
     #[serde(default, deserialize_with = "empty_is_none", alias = "build_gha")]
     pub build_action: Option<String>,
 
-    #[serde(default, deserialize_with = "empty_is_none")]
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_script: Option<String>,
-
-    #[serde(default, deserialize_with = "empty_is_none")]
-    #[deprecated(note = "no repository publishes build logs or scripts anymore")]
-    pub build_log: Option<String>,
-
     #[serde(alias = "category")]
     pub categories: Option<Vec<String>>,