fix(nix): compat53 version compat - #461
Conversation
|
That's a bad AI PR if you ask me. Why not fix the version constraint for non-Nix users too - straight in https://github.com/pinnacle-comp/pinnacle/blob/main/api/lua/pinnacle-api-dev-1.rockspec ? |
There's no need for that. You don't know if AI was used or not. And even if that was the case, it's not helpful.
I agree with that part, but |
Maybe use: |
?? I linked the upstream commit this is based on.
I'm not positive whether that can be done without needing to cut a new release + bump the version. I figured this was a minimal change to unbreak the nix package. I don't even think this is broken if you're not using nix as you can still access the older version of compat53. nix just doesn't offer multiple versions of the same package by default, hence this patch step. edit: I've also pinned back libdisplay-info to v0.3 as that's another breakage with this package (matching nixpkgs PR). clippy is breaking in CI -- not positive what's changed to prompt that yet. |
ca51574 to
239026c
Compare
239026c to
49ecbb1
Compare
nixpkgs updated the version of compat53 to 0.15. this updates the package here to match upstream so the package works with both pre-compat53 update and post-.