Skip to content

fix(nix): compat53 version compat - #461

Open
cassandracomar wants to merge 2 commits into
pinnacle-comp:mainfrom
cassandracomar:fix/compat53-version
Open

fix(nix): compat53 version compat#461
cassandracomar wants to merge 2 commits into
pinnacle-comp:mainfrom
cassandracomar:fix/compat53-version

Conversation

@cassandracomar

Copy link
Copy Markdown
Contributor

nixpkgs updated the version of compat53 to 0.15. this updates the package here to match upstream so the package works with both pre-compat53 update and post-.

@cassandracomar cassandracomar changed the title fix(nix): update compat53 version fix(nix): compat53 version compat Jul 15, 2026
@doronbehar

Copy link
Copy Markdown
Contributor

That's a bad AI PR if you ask me. Why not fix the version constraint for non-Nix users too - straight in https://github.com/pinnacle-comp/pinnacle/blob/main/api/lua/pinnacle-api-dev-1.rockspec ?

doronbehar added a commit to doronbehar/pinnacle that referenced this pull request Jul 26, 2026
doronbehar added a commit to doronbehar/pinnacle that referenced this pull request Jul 26, 2026
doronbehar added a commit to doronbehar/pinnacle that referenced this pull request Jul 26, 2026
@Ph4ntomas

Copy link
Copy Markdown
Contributor

That's a bad AI PR if you ask me.

There's no need for that. You don't know if AI was used or not. And even if that was the case, it's not helpful.

Why not fix the version constraint for non-Nix users too - straight in https://github.com/pinnacle-comp/pinnacle/blob/main/api/lua/pinnacle-api-dev-1.rockspec ?

I agree with that part, but >= isn't the best without additional constraints, so maybe ~> 0.15 would be better here.

@doronbehar

doronbehar commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

>= isn't the best without additional constraints, so maybe ~> 0.15 would be better here.

Maybe use:

compat53 >= 0.13, < 0.16,

@cassandracomar

cassandracomar commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

That's a bad AI PR if you ask me.

?? I linked the upstream commit this is based on.

Why not fix the version constraint for non-Nix users too

I'm not positive whether that can be done without needing to cut a new release + bump the version. I figured this was a minimal change to unbreak the nix package. I don't even think this is broken if you're not using nix as you can still access the older version of compat53. nix just doesn't offer multiple versions of the same package by default, hence this patch step.

edit: I've also pinned back libdisplay-info to v0.3 as that's another breakage with this package (matching nixpkgs PR). clippy is breaking in CI -- not positive what's changed to prompt that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants