Repository navigation
feat: drop Slack/web-push, use CDK js-core (DO NOT MERGE until core is published) - #100
Merged
Merged
Conversation
…core client. Do not publish until @notificationapi/core with the CDK paths is released and this package is bumped to it. Co-authored-by: Cursor <[email protected]>
…ht configuration.
millerm30
marked this pull request as draft
September 17, 2026 16:23
millerm30
marked this pull request as ready for review
September 18, 2026 12:58
sahandseifi
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet
Do not merge this until
@notificationapi/corewith the CDK in-app paths is merged and published. Then bump@notificationapi/corein this package to that published version and only then merge.Order:
serverlessnotificationapi-js-core@notificationapi/coredependency to that releaseSummary
@notificationapi/core@^1.2.9until the new core is publishedTest plan
file:) and re-test before mergeMade with Cursor