Repository navigation
ci: fix macOS cache saves on Hermes - #110
Merged
Merged
Conversation
Pin platform caching to our tested rust-cache fork so a sandbox-denied sudo launch cannot abort the optional purge workaround and cache upload. Preserve runner isolation, cache save conditions, and existing coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hermes denies the cache action's optional
sudo purgelaunch. The upstream action can then exit successfully without uploading a cache. Pin the platform job to the same patched action already verified with a real cache upload and subsequent restore in Pichi.Runner permissions, wipes, cache save conditions, and existing tests are unchanged. The Linux-only lint job retains its existing action reference.
Validation:
git diff --checkand gitlint pass. The pinned action builds reproducibly and has passed launch-error regression tests and Pichi's main-branch save/restore checks. Dillo-specific main-branch cache validation follows deployment.Upstream tracking: Swatinem/rust-cache#400 (currently closed without merging). Keep the pinned fork until an upstream revision contains the fix.