Repository navigation
Ask before deleting accounts and categories - #9
Merged
Merged
Conversation
Deleted accounts left their transactions behind, so they still showed in the transaction list and counted towards the overview totals. Deleting an account now removes its transactions too and unlinks its subscriptions, and startup cleans up accounts that were deleted before this change. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The delete button removed the account straight away. It now opens the same confirmation dialog as transactions and subscriptions, and says how many transactions go with the account. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The trash button removed the category straight away. It now asks first and says how many transactions will be left without a category. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Owner
|
Thank you @humber-web & @humbertic I saw this late but I have merged it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting an account or a category happened on a single click. Both now use the existing
ConfirmDialog, like transactions and subscriptions do, and say what goes with them ("…and its 42 transactions" / "Its 12 transactions will be kept without a category").It also fixes a bug: a deleted account's transactions stayed in the transaction list and kept counting towards the overview totals. Deleting an account now soft-deletes its transactions and unlinks its subscriptions. Startup also cleans up accounts that were deleted before this change.
cargo testpasses (180)🤖 Generated with Claude Code