Repository navigation
fix: refresh main view history id after reload - #4510
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4507
After a full reload, the browser retains the current history entry while the main LiveView gets a new id. The initial join previously left an existing history entry unchanged, so returning to it after a patch failed the main-view id check and remounted the view.
Refresh the current entry's id when the main view joins, preserving its existing navigation metadata and position. Keep the existing initialization for entries without history state.
The regression test starts with history state from a previous document, checks the joined view's id and history position, then simulates a patch and back traversal and checks that it patches the connected view instead of replacing it.
Testing and validation
npm run js:test -- --runInBand assets/test/view_test.ts assets/test/live_socket_test.ts --coverage=falseAI assistance: Codex was used to prepare this change and its regression test.