Skip to content

fix: refresh main view history id after reload - #4510

Open
pcbeingused333 wants to merge 2 commits into
phoenixframework:mainfrom
pcbeingused333:fix/4507-reload-history
Open

pcbeingused333 wants to merge 2 commits into
phoenixframework:mainfrom
pcbeingused333:fix/4507-reload-history

Conversation

@pcbeingused333

Copy link
Copy Markdown

Fixes #4507

After a full reload, the browser retains the current history entry while the main LiveView gets a new id. The initial join previously left an existing history entry unchanged, so returning to it after a patch failed the main-view id check and remounted the view.

Refresh the current entry's id when the main view joins, preserving its existing navigation metadata and position. Keep the existing initialization for entries without history state.

The regression test starts with history state from a previous document, checks the joined view's id and history position, then simulates a patch and back traversal and checks that it patches the connected view instead of replacing it.

Testing and validation

npm run js:test -- --runInBand assets/test/view_test.ts assets/test/live_socket_test.ts --coverage=false

AI assistance: Codex was used to prepare this change and its regression test.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Back after a reload remounts: history.state keeps the previous view's id

1 participant