ci: run tap validation on workflow changes and on demand - #51
Merged
Merged
Conversation
The workflow only triggered on phase.rb changes, so edits to the workflow itself (like the runner matrix update in #50) never ran until the next release. Add the workflow file to the path filters and add workflow_dispatch for manual runs. Manual runs install from the tap on main and from the checked-out formula on any other branch. Disable fail-fast so one failing runner doesn't cancel the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tap validation only ran when
phase.rbchanged. As a result, #50 (new macOS runner list) ran no CI on the PR or onmain, and the new runners would first run during the next release.Workflow file added to the
pathsfilters forpushandpull_request. Changes to this workflow now test themselves, starting with this PR.workflow_dispatchadded so the validation can be run from the Actions tab at any time, for example after GitHub movesmacos-latestto a new image.Install step conditions updated to cover manual runs:
pull_requestphase.rbpushtomainworkflow_dispatchonmainworkflow_dispatchon another branchphase.rbPreviously a manual run would have skipped both install steps and failed at the version check.
fail-fast: false, so one failing runner doesn't cancel the rest and every OS/arch result is visible.Testing
This PR touches the workflow file, so it triggers the full five-runner validation (
macos-15,macos-15-intel,macos-26,macos-26-intel,macos-latest) against the currentphase.rb.