configure: fix libbz2 detection on GCC 14 and newer - #47
Open
evs38 wants to merge 1 commit into
Open
Conversation
|
This fixed the issue with compiling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conftest for libbz2 passed (unsigned long*) as the destLen argument
of BZ2_bzBuffToBuffCompress() and BZ2_bzBuffToBuffDecompress(), while
bzlib.h declares both as unsigned int*.
Up to GCC 13 this was only a -Wincompatible-pointer-types warning, so
the test still linked and bzip2 support was detected. GCC 14 promotes
-Wincompatible-pointer-types to an error by default, so the conftest
fails to compile and configure reports:
regardless of bzip2 headers and libraries being installed. Building on
AlmaLinux 10 (GCC 14.3.1) reproduces this.
Note that the neighbouring zlib check is correct as it stands: zlib
declares the same argument as uLongf*, i.e. unsigned long*.
Both mkfls/unix/configure.in and the shipped mkfls/unix/configure are
updated, since the latter is what users actually run.