[ENHANCEMENT] Use areaOpacity for sparkline from theme#546
Conversation
Signed-off-by: Belyakin Alexander <[email protected]>
| areaStyle: { | ||
| color, | ||
| opacity: 0.4, | ||
| opacity: chartsTheme.sparkline.areaOpacity, |
There was a problem hiding this comment.
We probably want to have opacity defined in StatChartSparklineOptions too 🤔
There was a problem hiding this comment.
Agreed. I added areaOpacity to StatChartSparklineOptions and wired it as an override (theme as default) for consistency with width.
Signed-off-by: Belyakin Alexander <[email protected]>
|
lgtm, but it will need new shared release before merging |
|
Ah no it will need to be added on CUE model and Go sdk too. |
|
@abelyakin |
|
Will fix tomorrow 👍 |
|
Hello @abelyakin, any chance you would like to continue to work on this PR ? I think the feature is still valid and wanted here ! |
|
Hi, @Nexucis |
Description
Minor change that makes sparkline use areaOpacity from theme. Same as other sparkline visual settings.
This PR depends on perses/shared#49
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes