Skip to content

test(sqoop): test concurrent Sqoop log isolation [PDI-20034][QUALITY-12403] - #3043

Merged
paulaclemente merged 1 commit into
masterfrom
pdi-20034-concurrent-sqoop-logging
Nov 20, 2026
Merged

paulaclemente merged 1 commit into
masterfrom
pdi-20034-concurrent-sqoop-logging

Conversation

@paulaclemente

@paulaclemente paulaclemente commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add a unit test for concurrent Sqoop execution log-channel isolation, covering Sqoop, Hadoop counter-like messages, and stderr.
  • Verify that each channel receives only its own messages and that the remaining execution continues logging after the other finishes.

Context

  • Original issue: PDI-20034.
  • Customer Success question about concurrent executions: comment 468670.
  • Related draft PR Pdi 20034 test #3015 contains the integration-test infrastructure; this PR targets master and does not depend on it.
  • Follow-up: QUALITY-12403 tracks an integration test in the next cycle.

Validation

  • mvn -o -q -pl kettle-plugins/sqoop/core -am -Dtest=AbstractSqoopJobEntryTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false test against master (6 tests passed).
  • This unit test simulates Sqoop/Hadoop log output; it does not run two real concurrent Sqoop imports. End-to-end isolation remains to be verified under QUALITY-12403.

@orca-security-eu orca-security-eu Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@paulaclemente
paulaclemente force-pushed the pdi-20034-concurrent-sqoop-logging branch from 15ab548 to d299e94 Compare November 20, 2026 18:37
@paulaclemente
paulaclemente changed the base branch from pdi-20034-test to master November 20, 2026 18:37
@buildguy

Copy link
Copy Markdown
Collaborator

@buildguy

Copy link
Copy Markdown
Collaborator

✅ Build finished in 2m 15s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
kettle-plugins/sqoop/core

👌 All tests passed!

Tests run: 32, Failures: 0, Skipped: 0    Test Results


ℹ️ This is an automatic message

@paulaclemente
paulaclemente marked this pull request as ready for review November 20, 2026 18:42
@paulaclemente
paulaclemente requested a review from a team as a code owner November 20, 2026 18:42
Copilot AI balanced review requested due to automatic review settings November 20, 2026 18:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues were identified for this test-only expansion of concurrent Sqoop log-channel isolation coverage.

No open issues 🎉

What changed in this PR

Adds unit-test coverage for concurrent Sqoop log-channel isolation without changing production code. The test simulates log output; end-to-end isolation remains outside this PR’s scope.

Changes:

  • Verify that concurrent executions receive only their own Sqoop, Hadoop counter-like, and stderr messages.
  • Confirm that the second execution continues logging after the first detaches.
  • Extend the test helper to create distinct Kettle log channels.
File Description
kettle-plugins/​sqoop/​core/​src/​test/​java/​org/​pentaho/​big/​data/​kettle/​plugins/​sqoop/​AbstractSqoopJobEntryTest.java Adds synchronized concurrent logging assertions and a helper for distinct log channels.

Review effort: Balanced

@paulaclemente
paulaclemente merged commit 5a784df into master Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants