Use postalcode layer instead of postal_code for OSM records - #147
Merged
Conversation
orangejulius
requested review from
Copilot and
missinglink
and removed request for
Copilot
July 28, 2026 21:16
This matches the layer used by WOF. Without this normalization, it's impossible to return both WOF and OSM postalcodes with a single `layers=` param for endpoints that support it.
orangejulius
force-pushed
the
fix-osm-postal_code-layer
branch
from
July 31, 2026 18:47
e535a26 to
bd601ab
Compare
Member
|
Hmm yeah, this highlights a bit of an issue with multiple-sources in that there needs to be a point where the disparate schemas become cohesive, or the API consumer will always need to understand and navigate the nuances of every source's schema. I think for now this is fine, in the future we may want to define a set of ENUMs which enumerate the available layers, such that |
missinglink
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the layer used by WOF. Without this normalization, it's impossible to return both WOF and OSM postalcodes with a single
layers=param for endpoints that support it.