Repository navigation
Conversation
Comments, docs and diagnostic messages now read as ordinary engineering: reviewer credits keep their issue numbers and reasons under a neutral name, temp paths use the project prefix, pointers to the contributor instructions and the territory map no longer name files outside the public tree, and generated-code notes say automatically generated. One changelog row the audit missed is included the same way. Follow-up for the owner: the GitLab token keychain entry is renamed to pdfluent-api in the two scripts and the runbook that read it, so rename the entry in the local keychain to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment, doc and diagnostic-message rewords so reviewer credits read as ordinary engineering. Issue numbers and reasons are unchanged everywhere.
What changed:
Behaviour:
Owner follow-up (required): rename the GitLab token entry in the local keychain to pdfluent-api, or the two scripts and the runbook step that read it will fail to find it.
Deliberately untouched: the attribution guard and its test vectors (they must show the forbidden forms to refuse them), the seeding script and its test, the human co-author trailer docs and tests, the history note and its generator, the feature-claim denylist, the benchmark's configured model id (the value it must send), and the tests that mirror the real territory-map layout.
Overlap with #11: this PR edits files #11 proposes to delete (docs/SYSTEM_MAP.md, docs/release/FIRST_BETA_OPERATOR_RUNBOOK.md, docs/content-sync/, scripts/worker-prompt.md). Either order merges sanely; if #11 lands first, those hunks drop.
Checks run: py_compile over all touched scripts, bash -n over touched shell, TOML/YAML parse of touched configs, and the test suites for the touched guards (every_guard_has_a_job, mirror_has_not_drifted, a_deletion_declares_itself, feature_gated_tests_run) — all pass.