Repository navigation
docs: record the tag rule test and the names the policy check reserves - #9
Merged
Merged
Conversation
The tag ruleset that requires ci-ok was tested in a throwaway repository and is the one applied here. The standards now list the harmless names the policy check rejects, since it does not follow scopes. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01EWVANCgSt8W3VxxxZyAyoD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Two documents catch up with what setting the repository up showed.
docs/repository-settings.md: GitHub does not document whether a required status check stops a tag on an untested commit. It was tested in a throwaway repository: a tag on a commit with no passingci-okwas refused, the owner's tag on a tested commit was accepted, and deleting a release tag was refused. Moving a tag was not tried. The page now states this and names--with-tag-checkas the applied variant.docs/plugin-standards.md: the policy check does not follow scopes, so a few harmless names fail it (spawnorexecFileas a variable name, a local namedprocessorwindow, a string literal inside a timer callback). The page now lists them, so the next plugin author does not find out the hard way.Plugin
repository
Access changes
None
Tests
npm run checkScreenshots
Not a UI change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EWVANCgSt8W3VxxxZyAyoD