Repository navigation
fix: scan HTML with a tokenizer, keep Node typings on 24 - #2
Merged
Merged
Conversation
The policy check found script elements with a regular expression, which misses end tags a browser accepts. CodeQL flagged it as js/bad-tag-filter. A small tokenizer replaces it and also reads URL values the way a browser does. Dependabot now ignores major updates of @types/node, which must match the Node 24 line Orca runs plugins on. The tag ruleset files drop a parameter GitHub does not store for tags, so the settings read-back reports no false difference. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01EWVANCgSt8W3VxxxZyAyoD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
checkHtmlfound script elements with a regular expression, which misses end tags a browser accepts (</script foo>, an end tag split across lines, an unclosed script). CodeQL flagged it asjs/bad-tag-filter(high) onmain. A small tokenizer replaces it. It also reads URL values the way a browser does, sojava	script:and similar forms are caught, and a label such as'Data: 5 GB'is no longer rejected as adata:URL.@types/nodeare ignored. The typings must match Node 24, the version Orca runs plugins on.updaterule drops a parameter GitHub does not store for tags, soapply-repo-settings.sh --read-backreports no false difference.Plugin
repository
Access changes
None
Tests
npm run check: formatting, policy, catalog and version checks pass; 143 of 143 script tests pass (131 before).apply-repo-settings.sh --read-back --with-tag-checkagainst a sandbox repository with the rulesets applied: 0 differences.Screenshots
Not a UI change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EWVANCgSt8W3VxxxZyAyoD