Skip to content

fix: scan HTML with a tokenizer, keep Node typings on 24 - #2

Merged
pblobp merged 1 commit into
mainfrom
fix/policy-html-script-scan
Nov 17, 2026
Merged

pblobp merged 1 commit into
mainfrom
fix/policy-html-script-scan

Conversation

@pblobp

@pblobp pblobp commented Nov 17, 2026

Copy link
Copy Markdown
Owner

What changed and why

  • Policy check: checkHtml found script elements with a regular expression, which misses end tags a browser accepts (</script foo>, an end tag split across lines, an unclosed script). CodeQL flagged it as js/bad-tag-filter (high) on main. A small tokenizer replaces it. It also reads URL values the way a browser does, so java&#9;script: and similar forms are caught, and a label such as 'Data: 5 GB' is no longer rejected as a data: URL.
  • Dependabot: major updates of @types/node are ignored. The typings must match Node 24, the version Orca runs plugins on.
  • Tag rulesets: the update rule drops a parameter GitHub does not store for tags, so apply-repo-settings.sh --read-back reports no false difference.

Plugin

repository

Access changes

None

Tests

  • npm run check: formatting, policy, catalog and version checks pass; 143 of 143 script tests pass (131 before).
  • The 10 new tokenizer tests fail against the old regular expression and pass with the tokenizer.
  • apply-repo-settings.sh --read-back --with-tag-check against a sandbox repository with the rulesets applied: 0 differences.

Screenshots

Not a UI change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EWVANCgSt8W3VxxxZyAyoD

The policy check found script elements with a regular expression,
which misses end tags a browser accepts. CodeQL flagged it as
js/bad-tag-filter. A small tokenizer replaces it and also reads URL
values the way a browser does.

Dependabot now ignores major updates of @types/node, which must match
the Node 24 line Orca runs plugins on.

The tag ruleset files drop a parameter GitHub does not store for tags,
so the settings read-back reports no false difference.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01EWVANCgSt8W3VxxxZyAyoD
@pblobp
pblobp merged commit 9b6dbbb into main Nov 17, 2026
9 checks passed
@pblobp
pblobp deleted the fix/policy-html-script-scan branch November 17, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant