Skip to content

Feature/pre 3440 multi shop configuration - #323

Closed
adumont-payplug wants to merge 6 commits into
developfrom
feature/PRE-3440_multi_shop_configuration
Closed

adumont-payplug wants to merge 6 commits into
developfrom
feature/PRE-3440_multi_shop_configuration

Conversation

@adumont-payplug

Copy link
Copy Markdown
Collaborator

Description

Motivation:

Related issue(s): Closes #


Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue) [ ]
  • ✨ New feature (non-breaking change that adds functionality) [ ]
  • 💥 Breaking change (fix or feature that causes existing functionality to change and that could impact other libs) [ ]
  • 🔧 Refactor (no functional changes, code improvement only) [ ]
  • 📦 Dependency update [ ]
  • 🔒 Security fix [ ]
  • 📝 Documentation update [ ]

Checklist

Code Quality

  • Code is linted and formatted
  • No unnecessary commented-out code or debug logs
  • No hardcoded values (use env variables or config)

Testing

  • Unit tests added / updated

Security & Ops

  • No sensitive data or secrets introduced
  • Logging and error handling are appropriate

- de-dup CB base-currency form errors, not just flashes
- flash() no longer throws with no request/session
- drop 8 dead gatewayFactoryName property declarations
- suppress PHPMD unused-param on shouldValidateBaseCurrency()
- assert PaymentMethodTypeExtension::getExtendedTypes()
- tighten PaymentMethodRepository docblocks to list<>
@adumont-payplug
adumont-payplug marked this pull request as draft September 14, 2026 10:03
@adumont-payplug
adumont-payplug added this pull request to stack #326 September 14, 2026 15:20
@adumont-payplug
adumont-payplug removed this pull request from stack #326 September 15, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant