feat: use Sakekeep in German - #101
Draft
patriksimms wants to merge 2 commits into
Draft
Conversation
Add Paraglide and German hyphenation dependencies for #98. Verify plural variants compile to correct German singular and plural. Legal text updates are deferred to the owner. AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-6
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Add cookie-based organizer language and independent book language for contributor forms, print defaults, and shared German hyphenation. Backfill existing projects to English and persist page-problem facts instead of translated prose. Localize application and Clerk UI text. Legal page bodies remain unchanged at Patrik's request. Clerk email language requires a separate dashboard configuration. Validate with 436 unit tests, browser workflow and rendering parity checks, type checking, lint, formatting, production build, and Compose configuration checks. Include matched local before/after evidence. Refs #98 and #101. AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-6
Owner
Author
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
German-speaking organizers and contributors can now use Sakekeep in German. Organizer language is remembered in a cookie; each new book has its own language, which controls the contributor form, print defaults, and hyphenation.
Validation: 436 unit tests and 24 browser tests passed, including German editor/preview/PDF parity and organizer/contributor language isolation. The two production smoke tests are intentionally skipped locally. Formatting, lint, type checking, production build, and both Compose checks pass.
Matched before/after screenshots use synthetic local data in the real app at 1440 × 1000. Evidence is attached to #98 and stored in
visual-artifacts/localization/.Deployment: run the database migrations. Configure German authentication emails separately in Clerk's dashboard; no new environment variables or services are needed. Patrik will update legal texts separately, as agreed. English-authored demo fixtures retain English book language.
Delivery status: Macroscope reports “Credit balance exhausted.” Its review cannot complete, so this PR remains draft pending that external gate.
Closes #98.
Implemented with GPT-6 in the Codex harness.