Port of dnwrnr fixes - #42
Merged
Merged
Conversation
Ports dnwrnr/sgp4@2462be1 "Add a new constant". `A3Ovk2` is derived purely from compile-time constants, so there is no reason to recompute it per instance and store it in `CommonConstants`.
Ports dnwrnr/sgp4@adc1c36 "Create function to compute perturbed values".
Ports dnwrnr/sgp4@836b67e "Use WrapTwoPI. Formatting and wrapping.".
Ports the periodics half of dnwrnr/sgp4@6982421 "Improve DeepSpacePeriodics.".
Ports the `theta` part of dnwrnr/sgp4@6982421 "Improve DeepSpacePeriodics.".
Ports the structural half of dnwrnr/sgp4@6982421 "Improve DeepSpacePeriodics.".
Ports dnwrnr/sgp4@a7d72d7 "Rename xincl to xinc. xincl is used to represent the original inclination.".
Owner
|
No problem. Ultimately, it's a tool like any other, and the user is as responsible for their PR as ever. |
Owner
|
And, thanks for porting these from the "upstream"! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of dnwrnr/sgp4#7
Disclosure: I had an AI help me do the porting.