Repository navigation
Round customer savings estimates - #5
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 806facd0d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| value = summary.get("estimated_value_usd") | ||
| if valid_number(hours) and valid_number(value): | ||
| pieces.extend((f"{hours:.1f}h est. saved", f"${value:,.2f} est. value")) | ||
| pieces.extend((f"{hours:.1f}h est. saved", f"${value:,.0f} est. value")) |
There was a problem hiding this comment.
For estimates whose fractional part is exactly 0.5 and whose integer part is even, Python's .0f formatting uses ties-to-even rounding, so values such as $1062.50 become $1,062 and $0.50 becomes $0. These estimates can occur naturally (the existing status-line fixture already uses 1062.5), and this will disagree with dashboard-style half-up rounding despite the change intending to match that display; apply an explicit decimal half-up rule before formatting. The same format behavior is also used by status.py.
Useful? React with 👍 / 👎.
Customer-facing dollar savings now use whole dollars in the Claude footer and local status report, matching the dashboard and avoiding false precision. The underlying aggregate arithmetic remains unchanged.
This publishes plugin version 1.6.5.
Validation:
python3 -m unittest discover -s tests -p 'test_*.py'(149 tests),git diff --check.