feat: validate connections and inspect values in editor - #42
Merged
Merged
Conversation
3 tasks done
philippjfr
marked this pull request as ready for review
September 28, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I integrated ReactFlow's drag-time connection validation and port/edge value inspection into the FlowDash editor. A side-effect-free
DataflowGraph.validate_connectionchecks declared port direction, duplicate connections, occupied single inputs, cycles, and scalar type compatibility before edge creation; the same rules supply rejection reasons during a drag. List inputs still accept multiple scalar sources. Hovering a port or edge now previews its current value by default, without an extra Paper inside the popup;popup_trigger,popup_hover_delay, andvalue_reprremain configurable.The ReactFlow dependency is raised to
>=0.5.0b0in bothpyproject.tomlandpixi.toml. Tests:PYTHON_GIL=1 pixi run test(330 passed, 2 skipped),PYTHON_GIL=1 pixi run -e test-ui pytest tests/ui --ui --browser chromium -n 1 --tb=short -q(2 passed), and pre-commit on edited files.Before: Invalid connections were created briefly before server rejection; inspecting a value required a click and showed a nested Paper. After: Drag targets show rejection reasons before connection, and hovering an existing port or edge shows the value on one popup surface. To try this locally, run
flowdash serve examples/complex_dataflow, open the editor, drag an output toward an incompatible or occupied input, then hover a port or existing edge.AI Disclosure
Tool & Model: Kilo Code + GPT-6 Sol
Usage: Implemented the editor integration, validation, tests, and PR description with AI assistance; reviewed the diff and ran the listed checks.
Checklist