Skip to content

Add a check for duplicated output-file when a module contains several qmd files #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etiennebacher merged 3 commits into from
Oct 24, 2026
+13 −0
Merged

Add a check for duplicated output-file when a module contains several qmd files #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1903267
init
etiennebacher Oct 23, 2026
6090f46
add fake module to test failure
etiennebacher Oct 23, 2026
962011b
remove fake module
etiennebacher Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/check_sidebars.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
# (sync_sidebars.r only rewrites explicit paths, so these would resolve
# against the website root rather than the module)
# - a listed page doesn't exist in the module
# - several .qmd files in a module render their slides to the same file
#
# Warnings (reported, but don't fail the check):
# - a module with a _sidebar.yml has a web page that the sidebar doesn't list
Expand Down Expand Up @@ -98,6 +99,18 @@ for (m in modules) {
web <- qmds[vapply(file.path(m, qmds), is_web_page, logical(1))]
sb <- file.path(m, "_sidebar.yml")

# slides output-file of each .qmd (relative to the module), NA if none
slides <- vapply(qmds, function(q) {
fmt <- front_matter(file.path(m, q))$format
out <- unlist(lapply(Filter(is.list, fmt[grepl("revealjs$", names(fmt))]), `[[`, "output-file"))
if (length(out)) file.path(dirname(q), out[[1]]) else NA_character_
}, character(1))
slides <- sub("^[.]/", "", slides[!is.na(slides)])
for (o in unique(slides[duplicated(slides)])) {
report("error", file.path(m, names(slides)[match(o, slides)]), sprintf(
"%s all render their slides to %s", paste(names(slides)[slides == o], collapse = ", "), o))
}

if (!file.exists(sb)) {
if (length(web) > 1) {
report("warning", file.path(m, "index.qmd"), sprintf(
Expand Down
Loading