Skip to content

feat(proxy): include time range in search stats logging #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eguguchkin merged 2 commits into from
Nov 9, 2026
Merged

feat(proxy): include time range in search stats logging #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
866b2ef
feat(proxy): include time range in search stats logging
eguguchkin Oct 28, 2026
008658c
Merge branch 'main' into 0-pass-from-to-into-logs
eguguchkin Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions proxy/search/ingestor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ const (
// SearchStats carries observability data collected while executing a search.
type SearchStats struct {
Query string
From seq.MID
To seq.MID
Size int
HasHist bool
HasAgg bool
Expand Down Expand Up @@ -113,6 +115,8 @@ func (si *Ingestor) Search(

stats = &SearchStats{
Query: string(sr.Q),
From: sr.From,
To: sr.To,
Size: sr.Size + sr.Offset,
HasHist: sr.Interval > 0,
HasAgg: len(sr.AggQ) > 0,
Expand Down
7 changes: 6 additions & 1 deletion proxyapi/grpc_v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,9 @@ func (g *grpcV1) doSearch(

obs := requestObservation{
start: time.Now(),
stats: &search.SearchStats{},
stats: &search.SearchStats{
Size: int(req.Size) + int(req.Offset),
},
}

span := trace.FromContext(ctx)
Expand All @@ -205,9 +207,12 @@ func (g *grpcV1) doSearch(
if req.Query == nil {
return nil, obs, status.Error(codes.InvalidArgument, "search query must be provided")
}
obs.stats.Query = req.Query.Query
if req.Query.From == nil || req.Query.To == nil {
return nil, obs, status.Error(codes.InvalidArgument, `search query "from" and "to" fields must be provided`)
}
obs.stats.From = seq.MID(req.Query.From.AsTime().UnixNano())
obs.stats.To = seq.MID(req.Query.To.AsTime().UnixNano())
if req.Offset != 0 && req.OffsetId != "" {
return nil, obs, status.Error(codes.InvalidArgument, `only one of "offset" and "offset_id" must be provided`)
}
Expand Down
2 changes: 2 additions & 0 deletions proxyapi/request_observation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ func (o *requestObservation) finish(method string, retErr error) {
fields := []zap.Field{
zap.String("method", method),
zap.String("query", o.stats.Query),
zap.String("from", o.stats.From.String()),
zap.String("to", o.stats.To.String()),
zap.Bool("agg", o.stats.HasAgg),
zap.Bool("hist", o.stats.HasHist),
zap.Int("size", o.stats.Size),
Expand Down
Loading