Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
- Coverage 80.09% 80.08% -0.01%
==========================================
Files 261 262 +1
Lines 19769 19790 +21
==========================================
+ Hits 15834 15849 +15
- Misses 3935 3941 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
forshev
force-pushed
the
0-record-marshaler
branch
2 times, most recently
from
October 26, 2026 15:03
290e082 to
82a8079
Compare
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
forshev
force-pushed
the
0-record-marshaler
branch
from
October 27, 2026 12:41
ba65ade to
0f5e204
Compare
eguguchkin
requested review from
cheb0,
eqimd and
moflotas
and removed request for
cheb0
October 29, 2026 09:38
forshev
force-pushed
the
0-record-marshaler
branch
from
October 30, 2026 15:50
0f5e204 to
5454b5e
Compare
eqimd
approved these changes
Nov 2, 2026
| // rowSchema renders raw data of StreamSearch records as human readable values according to the Typing from header. | ||
| type rowSchema []*Typing | ||
|
|
||
| func newRowSchema(typing []*Typing) *rowSchema { |
Contributor
There was a problem hiding this comment.
nit: why not just return rowSchema and make all functions below on struct? (e.g. func (s rowSchema) render)
so there will be no need to dereference any pointers
forshev
force-pushed
the
0-record-marshaler
branch
from
November 5, 2026 13:08
a786039 to
b70b1b8
Compare
forshev
force-pushed
the
0-record-marshaler
branch
from
November 5, 2026 13:39
b70b1b8 to
c1236dd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add schema aware grpc gateway response rewriter for stream search