Repository navigation
Correct artifact action version comments - #132
Merged
Merged
Conversation
Set the upload and download action comments to v7.0.1 and v8.0.1 to match their pinned commits and resolve the two zizmor findings. No hashes or workflow behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why:
Update the upload and download action version comments in
.github/workflows/release.ymlfrom v7 and v8 to v7.0.1 and v8.0.1, respectively.The pinned hashes match those exact version tags. The floating v7 and v8 tags now point to newer commits, so the existing comments cause two medium findings in the security workflow’s zizmor online audit, failing every pull request.
Only the comments change. The pinned hashes and workflow behaviour remain unchanged.
Tests:
Only the existing audit output was read. No tests or audit reruns were performed.
Expected result after this change: the zizmor online audit reports no findings for these two lines.
Changelog:
Not user visible; no changelog entry.