Repository navigation
fix: resolve Rust 2021 prefix errors in prewarm format! calls - #181
Merged
Likhithsai2580 merged 5 commits intoOct 16, 2026
Merged
Likhithsai2580 merged 5 commits into
Likhithsai2580 merged 5 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
added 3 commits
October 16, 2026 18:44
- Rename 4-arg searxng_url(base, query, geo, lang) to searxng_url_with_geo to resolve E0428 (name defined multiple times with 0-arg searxng_url()) - Fix E0308: pass &searxng_url() where &str expected in searxng_url_with_categories callers - Fix E0308: change Vec<&str> to Vec<String> for searx_base_urls - Fix searx_instance_keys_for signature to accept &[String]
- starts_with(&searxng_url()) instead of starts_with(searxng_url()) - test arrays use String instead of &str literals - key_of closure takes &[String] instead of &[&str] - vpn_only test uses Vec<String> instead of Vec<&str>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI regression on auto/round-2026-10-12T1709Z.
Root cause: format!("{}", url())?q=... — the ? try operator followed immediately by an identifier (q=...) is parsed as a Rust 2021 prefixed identifier/literal, causing 'prefix X is unknown' compile errors.
Fix: move query parameters inside the format string: format!("{}/search?q=...", url())
Fixes all 8 occurrences in the prewarm block and handle_search/handle_search_fast.